fix-biz-stop (#414)

sofastack · Oct 14, 2020 · 92ed30b · 92ed30b
1 parent 1250449
commit 92ed30b
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/sofa-ark-parent/core/api/src/main/java/com/alipay/sofa/ark/api/ArkClient.java b/sofa-ark-parent/core/api/src/main/java/com/alipay/sofa/ark/api/ArkClient.java
@@ -169,13 +169,13 @@ public static ClientResponse installBiz(File bizFile, String[] args) throws Thro
             response.setCode(ResponseCode.FAILED).setMessage(
                 String.format("Install Biz: %s fail.", biz.getIdentity()));
             LOGGER.error(response.getMessage(), throwable);
-
-            bizManagerService.unRegisterBizStrictly(biz.getBizName(), biz.getBizVersion());
             try {
                 biz.stop();
             } catch (Throwable e) {
                 LOGGER.error(String.format("UnInstall Biz: %s fail.", biz.getIdentity()), e);
                 throw e;
+            } finally {
+                bizManagerService.unRegisterBizStrictly(biz.getBizName(), biz.getBizVersion());
             }
             return response;
         }
@@ -213,6 +213,8 @@ public static ClientResponse uninstallBiz(String bizName, String bizVersion) thr
                 LOGGER
                     .error(String.format("UnInstall Biz: %s fail.", biz.getIdentity()), throwable);
                 throw throwable;
+            } finally {
+                bizManagerService.unRegisterBizStrictly(biz.getBizName(), biz.getBizVersion());
             }
             response.setCode(ResponseCode.SUCCESS).setMessage(
                 String.format("Uninstall biz: %s success.", biz.getIdentity()));