rename heartbeat_delay to server_heartbeat_interval#47
Open
potatosalad wants to merge 1 commit intosockjs:devfrom
Open
rename heartbeat_delay to server_heartbeat_interval#47potatosalad wants to merge 1 commit intosockjs:devfrom
potatosalad wants to merge 1 commit intosockjs:devfrom
Conversation
Contributor
|
Hi @potatosalad - thanks for the patch. I'm going to review #69 first, and once that's merged I'll attend to this. Hopefully within the week. |
Contributor
Yeah, that didn't happen. I'll try and look at it this week instead. |
Author
|
@hyperthunk Also of note is the potatosalad/sockjs-erlang:work-features-20130621 branch which is what I'm currently using in production. It includes (along with all of the merge conflicts resolved):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same change as the one for sockjs/sockjs-node#69