Add option to disableEventMessageParsing and receive messages as Strings#1331
Open
lavenj wants to merge 3 commits intosocketio:developmentfrom
Open
Add option to disableEventMessageParsing and receive messages as Strings#1331lavenj wants to merge 3 commits intosocketio:developmentfrom
lavenj wants to merge 3 commits intosocketio:developmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @nuclearace! Not sure where I should direct this, but I had a need to parse my own messages on a version two(?) websocket that doesn't support binary data, and added a new config option:
If enabled, event messages are received like so:
And
emit()calls don't do any further parsing of their data argument, and are expected to look something like:I'm sure there's a more beautiful way of implementing this, but I wanted to keep changes minimal.
Upside for me is easy parsing from/to strongly typed objects using Codable
Any interest in merging?
Example usage:
Parsing/Decoding: