Fix connection error handling if the connection state is wrong#1233
Open
allenlinli wants to merge 3 commits intosocketio:developmentfrom
Open
Fix connection error handling if the connection state is wrong#1233allenlinli wants to merge 3 commits intosocketio:developmentfrom
allenlinli wants to merge 3 commits intosocketio:developmentfrom
Conversation
Member
|
@allenlinli Looks like that test failed |
Author
|
I see, I'll fix it in the next week. |
allenlinli
force-pushed
the
debug/connectErrorHandling
branch
2 times, most recently
from
69b0062 to
76a96ad
Compare
Author
|
Sorry for the late update. Here is the fix. |
allenlinli
force-pushed
the
debug/connectErrorHandling
branch
from
76a96ad to
20c7421
Compare
allenlinli
force-pushed
the
debug/connectErrorHandling
branch
from
20c7421 to
f2c892b
Compare
|
Hi can we merge this into develop? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testConnectedAlready