Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize & extend #12

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

sebakerckhof
Copy link
Contributor

This is way bigger than what one PR should contain and you may not want all of these changes, but I just wanted to give back the improvements I've done on the library on our private NPM space.

The major things are:

  • Rewritten from commonjs to ES modules
  • Added tooling to compile back down (also for testing)
  • Changed some linting rules to be more up to date with current best practices
  • Upgraded all dependencies to their latest versions (except for xmldom because of: Namespace propagation is no working correctly jindw/xmldom#215 )
  • Other ES2017 enhancements such as async/await, object rest/spread etc.
  • Replaced all querystring/url handling with the new node 8 URL api (WHATWG URL api)
  • Added support for some authentication request options around the context classes (you can now specify the request authentication context classes, the comparison and whether to hide the object in general).
  • Fixed some minor bugs

Because of the new URL api and ES features, the minimum compatible version is now node 8.

@AndrewCsontos AndrewCsontos marked this pull request as draft July 19, 2020 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant