feat: parse legacy CLI stdout workflow.Data and convert to issues [IDE-1697]

[acke]

IDE-1697 – Legacy CLI flow for ostest

Changes

• ostest_scan.go: In processOsTestWorkFlowData, branch on content_type.LEGACY_CLI_STDOUT; parse payload with UnmarshallOssJson and convertScanResultToIssues.
• converter.go / oss_test.go: Support for legacy JSON parsing and tests.

Depends on

• go-application-framework IDE-1697 (LEGACY_CLI_STDOUT + legacy_workflow).
• cli-extension-os-flows IDE-1697 (emitting LEGACY_CLI_STDOUT data).

Made with Cursor

[snyk-io]

⚠️ Snyk checks are incomplete.

Status	Scanner	Critical	High	Medium	Low	Total (0)
⚠️	Open Source Security	0	0	0	0	See details
⚠️	Licenses	0	0	0	0	See details
✅	Code Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[snyk-pr-review-bot]

PR Reviewer Guide 🔍

🧪 PR contains tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Error Handling The processOsTestWorkFlowData function returns immediately upon encountering an error during conversion (line 139) or unmarshalling (line 159). If the scanOutput can contain multiple independent workflow.Data entries, this "fail-fast" approach might lead to loss of other valid scan results. Consider logging the errors and continuing to process other data entries, aggregating partial results for increased resilience, if that aligns with the intended behavior for mixed workflow.Data types. return nil, fmt.Errorf("couldn't convert test result to issues: %w", err) } Test Content Type Line 519 changes the content type from a generic "application/json" to content_type.UFM_RESULT. While this aligns with the new branching logic in processOsTestWorkFlowData for Unified Findings Model results, ensure there is also a test case specifically for content_type.LEGACY_CLI_STDOUT data, as described in the PR description, to fully validate the new legacy parsing logic. data := workflow.NewData(workflow.NewTypeIdentifier(workflow.NewWorkflowIdentifier("test"), "payload"), content_type.UFM_RESULT, []byte("{}"))

📚 Repository Context Analyzed This review considered 23 relevant code sections from 12 files (average relevance: 0.88) infrastructure/code/code_test.go (2 segments, lines 1-54) infrastructure/code/convert.go (2 segments, lines 1-46) infrastructure/code/convert_test.go (lines 787-1023) infrastructure/code/code.go (lines 1-537) application/server/server_smoke_test.go (2 segments, lines 1-58) infrastructure/code/issue_enhancer_test.go (lines 1-248) domain/ide/workspace/folder_test.go (lines 1-638) ... and 5 more file(s)