Skip to content

chore: enable initial version of ufm sarif renderer #6277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2025
+9 −14
Merged

chore: enable initial version of ufm sarif renderer #6277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions cliv2/cmd/cliv2/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import (
"github.com/rs/zerolog"
"github.com/snyk/error-catalog-golang-public/code"
"github.com/snyk/error-catalog-golang-public/snyk_errors"
testapimocks "github.com/snyk/go-application-framework/pkg/apiclients/mocks"
"github.com/snyk/go-application-framework/pkg/apiclients/testapi"
"github.com/snyk/go-application-framework/pkg/configuration"
localworkflows "github.com/snyk/go-application-framework/pkg/local_workflows"
Expand Down Expand Up @@ -258,17 +257,13 @@ func Test_getErrorFromWorkFlowData(t *testing.T) {
engine := workflow.NewWorkFlowEngine(configuration.New())
assert.NoError(t, engine.Init())

localFailValue := testapi.Fail
localPassValue := testapi.Pass
mockController := gomock.NewController(t)

ufmTestResultFail := testapimocks.NewMockTestResult(mockController)
ufmTestResultFail.EXPECT().GetPassFail().Return(&localFailValue).AnyTimes()
ufmDataFail := ufm.CreateWorkflowDataFromTestResults(workflow.NewWorkflowIdentifier("test"), []testapi.TestResult{ufmTestResultFail})
ufmTestResultFail, err := ufm.NewSerializableTestResultFromBytes([]byte(`[{"testId": "f47ac10b-58cc-4372-a567-0e02b2c3d479", "passFail": "` + testapi.Fail + `", "findings": []}]`))
assert.NoError(t, err)
ufmDataFail := ufm.CreateWorkflowDataFromTestResults(workflow.NewWorkflowIdentifier("test"), ufmTestResultFail)

ufmTestResultPass := testapimocks.NewMockTestResult(mockController)
ufmTestResultPass.EXPECT().GetPassFail().Return(&localPassValue).AnyTimes()
ufmDataPass := ufm.CreateWorkflowDataFromTestResults(workflow.NewWorkflowIdentifier("test"), []testapi.TestResult{ufmTestResultPass})
ufmTestResultPass, err := ufm.NewSerializableTestResultFromBytes([]byte(`[{"testId": "f47ac10b-58cc-4372-a567-0e02b2c3d479", "passFail": "` + testapi.Pass + `", "findings": []}]`))
assert.NoError(t, err)
ufmDataPass := ufm.CreateWorkflowDataFromTestResults(workflow.NewWorkflowIdentifier("test"), ufmTestResultPass)

t.Run("nil error", func(t *testing.T) {
err := getErrorFromWorkFlowData(engine, nil)
Expand Down
2 changes: 1 addition & 1 deletion cliv2/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ require (
github.com/snyk/cli-extension-sbom v0.0.0-20251015130320-94416bf727b1
github.com/snyk/container-cli v0.0.0-20250321132345-1e2e01681dd7
github.com/snyk/error-catalog-golang-public v0.0.0-20251024131459-25bdd340f134
github.com/snyk/go-application-framework v0.0.0-20251031085153-663fef5db9c1
github.com/snyk/go-application-framework v0.0.0-20251103130335-efdf94f3a9f9
github.com/snyk/go-httpauth v0.0.0-20240307114523-1f5ea3f55c65
github.com/snyk/snyk-iac-capture v0.6.5
github.com/snyk/snyk-ls v0.0.0-20251017160427-ffbbccc59321
Expand Down
4 changes: 2 additions & 2 deletions cliv2/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1300,8 +1300,8 @@ github.com/snyk/container-cli v0.0.0-20250321132345-1e2e01681dd7 h1:/2+2piwQtB9f
github.com/snyk/container-cli v0.0.0-20250321132345-1e2e01681dd7/go.mod h1:38w+dcAQp9eG3P5t2eNS9eG0reut10AeJjLv5lJ5lpM=
github.com/snyk/error-catalog-golang-public v0.0.0-20251024131459-25bdd340f134 h1:IKwMDrwicB07NDS+VrI6I8qowqdDpKI0nBEvMnbSu+w=
github.com/snyk/error-catalog-golang-public v0.0.0-20251024131459-25bdd340f134/go.mod h1:Ytttq7Pw4vOCu9NtRQaOeDU2dhBYUyNBe6kX4+nIIQ4=
github.com/snyk/go-application-framework v0.0.0-20251031085153-663fef5db9c1 h1:wgQdugaKhCFEANKIoWoTdVFlQj00okOqMsbK8H6WZxU=
github.com/snyk/go-application-framework v0.0.0-20251031085153-663fef5db9c1/go.mod h1:Ni6yr7smQ85fPlbFEOkoUl32rNRQ9BwNa6ro06wQzXQ=
github.com/snyk/go-application-framework v0.0.0-20251103130335-efdf94f3a9f9 h1:3Us55OOzKMeujjp4T+mfS7rx0sQAV0u1oRdAyIl4hY8=
github.com/snyk/go-application-framework v0.0.0-20251103130335-efdf94f3a9f9/go.mod h1:Ni6yr7smQ85fPlbFEOkoUl32rNRQ9BwNa6ro06wQzXQ=
github.com/snyk/go-httpauth v0.0.0-20240307114523-1f5ea3f55c65 h1:CEQuYv0Go6MEyRCD3YjLYM2u3Oxkx8GpCpFBd4rUTUk=
github.com/snyk/go-httpauth v0.0.0-20240307114523-1f5ea3f55c65/go.mod h1:88KbbvGYlmLgee4OcQ19yr0bNpXpOr2kciOthaSzCAg=
github.com/snyk/policy-engine v1.1.0 h1:vFbFZbs3B0Y3XuGSur5om2meo4JEcCaKfNzshZFGOUs=
Expand Down