SNOW-2671717: Async connect context manager support - approach 1 - idempotent __aenter__ through checking if conn closed #2614
+335
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
cherrypicks-to-aio-connector-part23a
to
dev/aio-connector
October 29, 2025 11:48
sfc-gh-fpawlowski
force-pushed
the
async-connect-context-manager-support
branch
from
eb41ffe to
61ba1dc
Compare
sfc-gh-turbaszek
approved these changes
Nov 3, 2025
…changes to skip fialing tests so lets fix in next commit
…changes to skip fialing tests so lets fix in next commit
sfc-gh-fpawlowski
force-pushed
the
async-connect-context-manager-support
branch
from
999cbf5 to
fad5e74
Compare
sfc-gh-fpawlowski
changed the title
| conn = SnowflakeConnection(**kwargs) | ||
| await conn.connect() | ||
| return conn | ||
| connect = Connect |
Contributor
Author
There was a problem hiding this comment.
Do we wish to repeat this "pattern" from the synch code? Are there any counterarguments of simply doing def connect(..):?
Contributor
There was a problem hiding this comment.
To me def connect is much more cleaner. Current state is caused by def Connect not complying to Python naming conventions, thus we have connect alias.
sfc-gh-turbaszek
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Approach 1 - idempotent aenter through checking if conn closed.
Main benefit - calling SnowflakeConnection.aenter in the snowflake.connector.aio.connect.aenter - we can feel safe from missing some logic there.
Main drawback - will always conn.is_closed() be reliable.
Analogous to: https://github.com/aio-libs/aiohttp/blob/master/aiohttp/client.py#L1376-L1412