SNOW-2057867 refactor and fixes to make stage related bind and pandas… #2300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… write work for Python sprocs - relax the condition of using stage solution for array bind (so we will use bind_size >= threshold instead of bind_size > threshold) - use _upload_stream to implement BindUploadAgent - use _upload to implement write_pandas - correctly use scoped keyword and temp naming pattern for write_pandas - fix a minor bug where file_transfer_agent returns meta.dst_file_name as file name in download (dst_file_name may contain sub-directories, whereas name will be the base file name without any sub-directory prefixes. We should keep it consistent with upload, where we use meta.name as file name ### Tests - the new test_direct_file_operation_utils.py to validate parse_file_operation for _upload and _upload_stream - existing test test_bindings.py to make sure the change does not break existing bind upload logic - existing test_pandas_tools.py to make sure the change does not break existing write_pandas logic
sfc-gh-zyao
requested review from
sfc-gh-sfan,
sfc-gh-aling and
sfc-gh-mmishchenko
sfc-gh-zyao
added
NO-CHANGELOG-UPDATES
|
This should be broken down into two PRs at least
|
sfc-gh-sfan
reviewed
Apr 28, 2025
| """Parses a file operation by constructing SQL and getting the SQL parsing result from server.""" | ||
| options_in_sql, option_bind_values = self._process_options_for_upload(options) | ||
|
|
||
| if command_type == CMD_TYPE_UPLOAD: |
There was a problem hiding this comment.
This does not look like a pure refactor. We do an assertion, a file name split and some escaping. These do not exist in the original code. Why are they required?
Comment on lines
+81
to
+84
| self.cursor._upload_stream( | ||
| input_stream=f, | ||
| stage_location=os.path.join(self.stage_path, f"{row_idx}.csv"), | ||
| options={}, |
There was a problem hiding this comment.
Is this correct? The original function use PUT which is somewhat equivalent to _upload?
| @@ -557,6 +561,7 @@ def mocked_execute(*args, **kwargs): | |||
| ) | |||
|
|
|||
|
|
|||
| # @pytest.mark.skipolddriver | |||
There was a problem hiding this comment.
nit: unintended change
|
Closing this PR, because we split it into 2 sub PRs
I will copy the comments over and address them in the split PRs instead |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… write work for Python sprocs
_upload_streamto implement BindUploadAgent_uploadto implement write_pandasTests
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #NNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.
(Optional) PR for stored-proc connector: