SNOW-2013774 support server side semi structured types bindings #2269
+200
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-mkubik
added
the
DO_NOT_PORT_CHANGES_TO_SP
# Conflicts: # src/snowflake/connector/connection.py
sfc-gh-mkubik
force-pushed
the
SNOW-2013774-support-server-side-semi-structured-types-bindings
branch
from
40b2c0d to
930573f
Compare
| cursor.execute( | ||
| bind_query, params=(["a", "b", "c"],), snowflake_type=snowflake_type | ||
| ) | ||
| cursor.execute(bind_query, params=([1, "2", 3],), snowflake_type=snowflake_type) |
There was a problem hiding this comment.
Was also an option to introduce a wrapper types or functions to point that a semi-structured binding should be used? I.e. in that case this line would look like:
cursor.execute(bind_query, params=(snow_array([1, "2", 3]),))
Or snow_object in the test below
There was a problem hiding this comment.
I didn't think of it but that's a pretty elegant idea, let me adjust the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
snowflake_typeparameter tocursor.executethat indicates what is the desired snowflake type. If it's one of the semi-structured types, there's a special handling that includes serialising the object to JSON string that gets passed to the backend with appropriate type.No snowflake_type provided or snowflake_type other than ARRAY, OBJECT or VARIANT doesn't change the processing flow. If user provides the primitive type e.g. BOOLEAN but the binding logic interprets it differently it results in a warning.