Skip to content

SNOW-2000709 add further integ/unit tests to guard the behaviors of n… #2230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

SNOW-2000709 add further integ/unit tests to guard the behaviors of n… #2230

wants to merge 1 commit into from
+164 −4

Conversation

sfc-gh-zyao
Copy link
Contributor

…o-auth

Description

  • this is a test-only change
  • Add more integ/unit tests to guard the behavior of no-auth
    • The goal is to avoid future changes accidentally and silently break the behavior of no-auth. (Eventually we want to have end-to-end tests to guard it when the Stored Procedure support is completed)

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

  4. (Optional) PR for stored-proc connector:

@sfc-gh-zyao sfc-gh-zyao marked this pull request as draft March 24, 2025 17:50
@sfc-gh-zyao sfc-gh-zyao force-pushed the zyao-SNOW-2000709-more-unit-test-to-protect-no-auth branch from 8fa0da2 to 44f02bd Compare March 24, 2025 17:52
@sfc-gh-zyao
SNOW-2000709 add further integ/unit tests to guard the behaviors of n…
c7cb6ed 
…o-auth

### Description
- Add more integ/unit tests to guard the behavior of no-auth
  - The goal is to avoid future changes accidentally and silently break the behavior of no-auth. (Eventually we want to have end-to-end tests to guard it when the Stored Procedure support is completed)
@sfc-gh-zyao sfc-gh-zyao force-pushed the zyao-SNOW-2000709-more-unit-test-to-protect-no-auth branch from 44f02bd to c7cb6ed Compare March 24, 2025 17:57
@sfc-gh-zyao sfc-gh-zyao added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector labels Mar 24, 2025
@sfc-gh-zyao sfc-gh-zyao marked this pull request as ready for review March 24, 2025 17:58
@sfc-gh-zyao sfc-gh-zyao requested a review from sfc-gh-sfan March 24, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-sfan sfc-gh-sfan sfc-gh-sfan approved these changes

Assignees
No one assigned
Labels
DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-zyao @sfc-gh-sfan