Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CODEOWNERS #2149

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Update CODEOWNERS #2149

merged 1 commit into from
Jan 28, 2025

Conversation

sfc-gh-jszczerbinski
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

  4. (Optional) PR for stored-proc connector:

@sfc-gh-jszczerbinski sfc-gh-jszczerbinski added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector labels Jan 24, 2025
@sfc-gh-jszczerbinski sfc-gh-jszczerbinski force-pushed the sfc-gh-jszczerbinski-patch-1 branch from 8bcb236 to bd905cc Compare January 28, 2025 14:50
sfc-gh-mkeller
sfc-gh-mkeller approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢

@sfc-gh-mkeller sfc-gh-mkeller force-pushed the sfc-gh-jszczerbinski-patch-1 branch from bd905cc to 8865a45 Compare January 28, 2025 18:06
@sfc-gh-mkeller sfc-gh-mkeller merged commit ec3002d into main Jan 28, 2025
93 checks passed
@sfc-gh-mkeller sfc-gh-mkeller deleted the sfc-gh-jszczerbinski-patch-1 branch January 28, 2025 20:08
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-mkeller sfc-gh-mkeller sfc-gh-mkeller approved these changes

Assignees
No one assigned
Labels
DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-jszczerbinski @sfc-gh-mkeller