SNOW-1825621 OAuth code flow PKCE support #2137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-mkeller
changed the title
sfc-gh-mkeller
force-pushed
the
mkeller/SNOW-1825621/pkce-support
branch
from
dc687f4 to
3684460
Compare
sfc-gh-mkeller
added
the
DO_NOT_PORT_CHANGES_TO_SP
| hashlib.sha256(self._verifier.encode("utf-8")).digest() | ||
| ) | ||
| .decode("utf-8") | ||
| .replace("=", "") |
There was a problem hiding this comment.
if it's URL-safe it shouldn't have any padding?
There was a problem hiding this comment.
from https://docs.python.org/3/library/base64.html#base64.urlsafe_b64encode
The result can still contain =.
Unfortunately this remains necessary
sfc-gh-mkeller
force-pushed
the
mkeller/SNOW-1825621/pkce-support
branch
from
4591ea1 to
6ae67ca
Compare
sfc-gh-mkeller
force-pushed
the
mkeller/SNOW-1825621/pkce-support
branch
from
6ae67ca to
81627af
Compare
7 tasks
sfc-gh-mkeller
changed the base branch from
main
to
mkeller/SNOW-1825621/oauth-code-flow-support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1825621
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
This PR builds on top of #2135 and it adds PKCE support on top of OAuth code flow.
This change has been tested manually, as it's fairly complicated to setup and we don't do unit tests for the different authentication methods.