Skip to content

SNOW-1825673 use tmdir in case of Permission error #2111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

mikita-sakalouski
Copy link

@mikita-sakalouski mikita-sakalouski commented Dec 2, 2024

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1825673

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    In case of permission error for directory, throw warning and continue

Copy link

github-actions bot commented Dec 2, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@mikita-sakalouski
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@mikita-sakalouski
Copy link
Author

recheck

@sfc-gh-mkeller
Copy link
Collaborator

We should not proceed with a temporary directory, we should just simply print a warning and move on I think.
I'd never expect the connections file to exist in a temp directory

@mikita-sakalouski
Copy link
Author

Yes, can do it. Was not sure if connector is accessing the directory for checking the file

@sfc-gh-dszmolka sfc-gh-dszmolka requested a review from a team December 3, 2024 14:59
@sfc-gh-dszmolka sfc-gh-dszmolka requested a review from a team March 12, 2025 12:37
@mikita-sakalouski
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@mikita-sakalouski
Copy link
Author

recheck

@sfc-gh-mkubik sfc-gh-mkubik added the DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector label Apr 3, 2025
@sfc-gh-mkubik sfc-gh-mkubik added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Apr 17, 2025
@sfc-gh-dszmolka sfc-gh-dszmolka requested a review from a team April 25, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants