SNOW-834807: Allow users to configure ServicePointManager.ConnectionLimit property #1224

sfc-gh-ext-simba-lf · 2025-08-20T01:49:40Z

Description

Allow users to configure ServicePointManager.ConnectionLimit property

Checklist

Code compiles correctly
Code is formatted according to Coding Conventions
Created tests which fail without the change (if possible)
All tests passing (dotnet test)
Extended the README / documentation, if necessary
Provide JIRA issue id (if possible) or GitHub issue id in PR name

…nector-net into SNOW-834807-Expose-ConnectionLimit

codecov · 2025-08-20T16:44:54Z

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
3368	1	3367	115

View the full list of 3 ❄️ flaky test(s)

Snowflake.Data.Tests.IntegrationTests.ConnectionPoolCommonIT(MultipleConnectionPool)::TestRollbackTransactionOnPooledWhenExceptionOccurred

Flake rate in main: 55.56% (Passed 4 times, Failed 5 times)

Stack Traces | 2.36s run time

at Snowflake.Data.Tests.IntegrationTests.ConnectionPoolCommonIT.TestRollbackTransactionOnPooledWhenExceptionOccurred() in D:\a\snowflake-connector-net\snowflake-connector-net\Snowflake.Data.Tests\IntegrationTests\ConnectionPoolCommonIT.cs:line 161

1)    at Snowflake.Data.Tests.IntegrationTests.ConnectionPoolCommonIT.TestRollbackTransactionOnPooledWhenExceptionOccurred() in D:\a\snowflake-connector-net\snowflake-connector-net\Snowflake.Data.Tests\IntegrationTests\ConnectionPoolCommonIT.cs:line 161

Snowflake.Data.Tests.UnitTests.Revocation.CrlCacheManagerTest::TestScheduledCleanupRemovesExpiredEntries

Flake rate in main: 20.00% (Passed 12 times, Failed 3 times)

Stack Traces | 1.54s run time

at Snowflake.Data.Tests.UnitTests.Revocation.CrlCacheManagerTest.TestScheduledCleanupRemovesExpiredEntries() in D:\a\snowflake-connector-net\snowflake-connector-net\Snowflake.Data.Tests\UnitTests\Revocation\CrlCacheManagerTest.cs:line 127

1)    at Snowflake.Data.Tests.UnitTests.Revocation.CrlCacheManagerTest.TestScheduledCleanupRemovesExpiredEntries() in D:\a\snowflake-connector-net\snowflake-connector-net\Snowflake.Data.Tests\UnitTests\Revocation\CrlCacheManagerTest.cs:line 127

Snowflake.Data.Tests.UnitTests.Revocation.CrlCacheManagerTest::TestScheduledCleanupRemovesStaleEntries

Flake rate in main: 20.00% (Passed 12 times, Failed 3 times)

Stack Traces | 1.53s run time

at Snowflake.Data.Tests.UnitTests.Revocation.CrlCacheManagerTest.TestScheduledCleanupRemovesStaleEntries() in D:\a\snowflake-connector-net\snowflake-connector-net\Snowflake.Data.Tests\UnitTests\Revocation\CrlCacheManagerTest.cs:line 166

1)    at Snowflake.Data.Tests.UnitTests.Revocation.CrlCacheManagerTest.TestScheduledCleanupRemovesStaleEntries() in D:\a\snowflake-connector-net\snowflake-connector-net\Snowflake.Data.Tests\UnitTests\Revocation\CrlCacheManagerTest.cs:line 166

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

…nector-net into SNOW-834807-Expose-ConnectionLimit # Conflicts: # Snowflake.Data/Core/HttpUtil.cs

sfc-gh-dszmolka · 2025-09-03T06:30:36Z

when you get there; would it be please possible to also extend the documentation @sfc-gh-ext-simba-lf ? Thank you in advance!

sfc-gh-ext-simba-lf · 2025-09-03T16:28:05Z

when you get there; would it be please possible to also extend the documentation @sfc-gh-ext-simba-lf ? Thank you in advance!

Sure, I'll update the docs as well

…nector-net into SNOW-834807-Expose-ConnectionLimit

Snowflake.Data.Tests/UnitTests/Session/SFHttpClientPropertiesTest.cs

Snowflake.Data/Core/HttpUtil.cs

Snowflake.Data/Core/Session/SFSessionProperty.cs

Snowflake.Data.Tests/UnitTests/Session/SFHttpClientPropertiesTest.cs

This reverts commit 25ba9d0.

This reverts commit 53ad053.

This reverts commit bf78e92.

sfc-gh-mgemra · 2025-10-13T10:36:46Z

Snowflake.Data.Tests/UnitTests/Session/SFHttpClientPropertiesTest.cs

+        }
+
+        [Test]
+        public void TestThrowsExceptionWhenSettingConnectionLimitPropertyToNonStringValue()


This is a string. Maybe TestThrowsExceptionWhenSettingConnectionLimitPropertyToNonNumericValue?

You could also add other test cases:
"abc", "1.5", "true", etc.

Renamed the test and also added the test cases mentioned above

sfc-gh-mgemra · 2025-10-13T10:41:31Z

Snowflake.Data/Core/Session/SFSessionHttpClientProperties.cs

+        {
+            if (_servicePointConnectionLimit < 1)
+            {
+                s_logger.Warn($"Connection limit cannot be less than 1. Using the default value of {DefaultConnectionLimit}");


Suggested change

s_logger.Warn($"Connection limit cannot be less than 1. Using the default value of {DefaultConnectionLimit}");

s_logger.Warn($"Connection limit must be a positive integer. Using the default value of {DefaultConnectionLimit}");

Changed the message to similar to the suggestion above and also mentioned the upper limit

sfc-gh-mgemra · 2025-10-13T10:44:25Z

Snowflake.Data/Core/Session/SFSessionHttpClientProperties.cs


+        private void ValidateConnectionLimit()
+        {
+            if (_servicePointConnectionLimit < 1)


Don't we need an upper limit here?
cc: @sfc-gh-mhofman

I'm not sure what the upper limit should be so it's currently set to 1000

Is there a specific upper limit you would like to use?

…nector-net into SNOW-834807-Expose-ConnectionLimit

sfc-gh-ext-simba-lf added 3 commits August 19, 2025 18:42

Add connection property for connection limit

69a202c

Add tests for new connection limit property

a33320b

Merge branch 'master' of https://github.com/snowflakedb/snowflake-con…

ab54c06

…nector-net into SNOW-834807-Expose-ConnectionLimit

sfc-gh-ext-simba-lf added 2 commits September 2, 2025 10:54

Merge branch 'master' of https://github.com/snowflakedb/snowflake-con…

3b789f6

…nector-net into SNOW-834807-Expose-ConnectionLimit # Conflicts: # Snowflake.Data/Core/HttpUtil.cs

Add value for connection limit parameter

51a57ba

Update docs

0129b2d

sfc-gh-ext-simba-lf marked this pull request as ready for review September 5, 2025 17:14

sfc-gh-ext-simba-lf requested a review from a team as a code owner September 5, 2025 17:14

sfc-gh-ext-simba-lf added 2 commits September 5, 2025 10:15

Trigger build checks

9c8378c

Trigger build checks

958411b

sfc-gh-ext-simba-lf requested a review from sfc-gh-knozderko September 6, 2025 00:09

sfc-gh-dszmolka mentioned this pull request Sep 8, 2025

SNOW-2262969: ServicePointManager.DefaultConnectionLimit Global Override Causes Performance Bottlenecks #1221

Open

Merge branch 'master' of https://github.com/snowflakedb/snowflake-con…

64e3588

…nector-net into SNOW-834807-Expose-ConnectionLimit

sfc-gh-dszmolka mentioned this pull request Sep 9, 2025

SNOW-357386: ConnectionLimit is hardcoded to 20, allow client to specify #316

Open

sfc-gh-knozderko reviewed Sep 12, 2025

View reviewed changes

Snowflake.Data.Tests/UnitTests/Session/SFHttpClientPropertiesTest.cs Show resolved Hide resolved

Snowflake.Data/Core/HttpUtil.cs Show resolved Hide resolved

sfc-gh-knozderko reviewed Sep 12, 2025

View reviewed changes

Snowflake.Data/Core/Session/SFSessionProperty.cs Outdated Show resolved Hide resolved

sfc-gh-ext-simba-lf added 3 commits September 12, 2025 10:32

Add tests for non string values

046d964

Rename new property to SERVICE_POINT_CONNECTION_LIMIT

fb095f3

Add more detail to docs about the connection limit

63cfb78

sfc-gh-knozderko suggested changes Sep 16, 2025

View reviewed changes

Snowflake.Data.Tests/UnitTests/Session/SFHttpClientPropertiesTest.cs Outdated Show resolved Hide resolved

Snowflake.Data.Tests/UnitTests/Session/SFHttpClientPropertiesTest.cs Show resolved Hide resolved

sfc-gh-ext-simba-lf added 4 commits September 16, 2025 10:55

Fix connection string

3870ebc

Change error thrown to SnowflakeDbException

25ba9d0

Modify tests for SnowflakeDbException

bf78e92

Modify tests for SnowflakeDbException

53ad053

sfc-gh-knozderko reviewed Sep 17, 2025

View reviewed changes

Snowflake.Data.Tests/UnitTests/Session/SFHttpClientPropertiesTest.cs Show resolved Hide resolved

Snowflake.Data.Tests/UnitTests/Session/SFHttpClientPropertiesTest.cs Outdated Show resolved Hide resolved

sfc-gh-ext-simba-lf added 2 commits September 17, 2025 10:42

Revert "Change error thrown to SnowflakeDbException"

22402af

This reverts commit 25ba9d0.

Revert "Modify tests for SnowflakeDbException"

9bbaa19

This reverts commit 53ad053.

sfc-gh-ext-simba-lf added 3 commits September 17, 2025 10:44

Revert "Modify tests for SnowflakeDbException"

d500980

This reverts commit bf78e92.

Validate property when parsing connection string

52b2004

gin S

53101c8

sfc-gh-ext-simba-lf requested a review from a team as a code owner October 7, 2025 16:44

sfc-gh-pszpakowski requested review from sfc-gh-daniszewski and sfc-gh-mgemra October 8, 2025 15:10

sfc-gh-mgemra reviewed Oct 13, 2025

View reviewed changes

sfc-gh-mgemra mentioned this pull request Oct 16, 2025

SNOW-2262969: Keep DefaultConnectionLimit if over 50 #1226

Open

6 tasks

sfc-gh-ext-simba-lf and others added 5 commits October 16, 2025 10:51

Rename test and add more cases

81b029a

Modified warning log

62b0922

Add upper limit for connection

8ed4cca

Merge branch 'master' of https://github.com/snowflakedb/snowflake-con…

fd95018

…nector-net into SNOW-834807-Expose-ConnectionLimit

Merge branch 'master' into SNOW-834807-Expose-ConnectionLimit

8f516ee

sfc-gh-mgemra approved these changes Oct 22, 2025

View reviewed changes

	s_logger.Warn($"Connection limit cannot be less than 1. Using the default value of {DefaultConnectionLimit}");
	s_logger.Warn($"Connection limit must be a positive integer. Using the default value of {DefaultConnectionLimit}");

SNOW-834807: Allow users to configure ServicePointManager.ConnectionLimit property #1224

Are you sure you want to change the base?

SNOW-834807: Allow users to configure ServicePointManager.ConnectionLimit property #1224

Conversation

sfc-gh-ext-simba-lf commented Aug 20, 2025

Description

Checklist

Uh oh!

codecov bot commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 1 Tests Failed:

Uh oh!

sfc-gh-dszmolka commented Sep 3, 2025

Uh oh!

sfc-gh-ext-simba-lf commented Sep 3, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sfc-gh-mgemra Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sfc-gh-mgemra Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

sfc-gh-ext-simba-lf Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

sfc-gh-mgemra Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

sfc-gh-ext-simba-lf Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

sfc-gh-mgemra Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

sfc-gh-ext-simba-lf Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Aug 20, 2025 •

edited

Loading

sfc-gh-mgemra Oct 13, 2025 •

edited

Loading