Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-985356 Do not start chunk downloader when first batch causes error #993

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Dec 7, 2023

Description

When error occurred when parsing first arrow batch, the error was just swallowed and empty struct was returned. This caused that when the struct was used, caused panic on nil field access.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e799467) 82.79% compared to head (3d4a605) 82.83%.
Report is 1 commits behind head on master.

Files Patch % Lines
chunk_downloader.go 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #993      +/-   ##
==========================================
+ Coverage   82.79%   82.83%   +0.04%     
==========================================
  Files          50       50              
  Lines        9687     9698      +11     
==========================================
+ Hits         8020     8033      +13     
+ Misses       1667     1665       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review December 7, 2023 11:23
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner December 7, 2023 11:23
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-985356-chunk-downloader-start branch from 49fe0a8 to 3d4a605 Compare December 7, 2023 11:30
@sfc-gh-pfus sfc-gh-pfus merged commit a4c3557 into master Dec 7, 2023
23 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-985356-chunk-downloader-start branch December 7, 2023 12:44
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants