Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-981533 Fix flaky test of retries #990

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Dec 6, 2023

Description

Fixes flaky test introduced when retry strategy changed.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b8e6736) 82.80% compared to head (32e7190) 82.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #990   +/-   ##
=======================================
  Coverage   82.80%   82.80%           
=======================================
  Files          50       50           
  Lines        9684     9684           
=======================================
  Hits         8019     8019           
  Misses       1665     1665           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review December 6, 2023 08:51
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner December 6, 2023 08:51
@sfc-gh-pfus sfc-gh-pfus merged commit 555fa7b into master Dec 6, 2023
23 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-981533-flaky-test branch December 6, 2023 09:06
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants