Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-981533 Separate retry strategy for auth endpoints and the remaining ones #982

Merged
merged 1 commit into from
Dec 4, 2023
Merged

SNOW-981533 Separate retry strategy for auth endpoints and the remaining ones #982

merged 1 commit into from
Dec 4, 2023

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Dec 1, 2023 •
edited
Loading

Description

Fixed retry algorithm. Before, only whitelisted endpoints were retried. Now it retries all endpoints. Also, there is a separate backoff logic for authentication endpoints.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-pfus sfc-gh-pfus force-pushed the getQueryStatus branch 2 times, most recently from a43197c to 1811d73 Compare December 1, 2023 11:41
@codecov Codecov
Copy link

codecov bot commented Dec 1, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (15fac29) 82.48% compared to head (29f6fce) 82.82%.
Report is 1 commits behind head on master.

Files Patch % Lines
retry.go 96.55% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #982      +/-   ##
==========================================
+ Coverage   82.48%   82.82%   +0.34%     
==========================================
  Files          50       50              
  Lines        9643     9660      +17     
==========================================
+ Hits         7954     8001      +47     
+ Misses       1689     1659      -30

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review December 1, 2023 12:58
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner December 1, 2023 12:58
@sfc-gh-pfus sfc-gh-pfus changed the title SNOW-981533 Separate retry strategy for auth endpoints and the remain… SNOW-981533 Separate retry strategy for auth endpoints and the remaining ones Dec 1, 2023
@sfc-gh-pfus sfc-gh-pfus merged commit d56c0f2 into master Dec 4, 2023
@sfc-gh-pfus sfc-gh-pfus deleted the getQueryStatus branch December 4, 2023 10:25
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dheyman sfc-gh-dheyman sfc-gh-dheyman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-pfus @sfc-gh-dheyman