Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-978164: Fix stmt.Exec for DML #978

Merged
merged 13 commits into from
Dec 4, 2023
Merged

SNOW-978164: Fix stmt.Exec for DML #978

merged 13 commits into from
Dec 4, 2023

Conversation

sfc-gh-pbulawa
Copy link
Collaborator

@sfc-gh-pbulawa sfc-gh-pbulawa commented Nov 29, 2023 •
edited
Loading

Description

Enable the usage of stmt.Exec/ExecContext for DML without returning the exception when used.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-pbulawa sfc-gh-pbulawa marked this pull request as ready for review November 29, 2023 16:06
@sfc-gh-pbulawa sfc-gh-pbulawa requested a review from a team as a code owner November 29, 2023 16:06
sfc-gh-pfus
sfc-gh-pfus reviewed Nov 30, 2023
View reviewed changes
connection.go Outdated Show resolved Hide resolved
connection_util.go Outdated Show resolved Hide resolved
sfc-gh-pfus
sfc-gh-pfus reviewed Nov 30, 2023
View reviewed changes
connection.go Outdated Show resolved Hide resolved
connection_util.go Outdated Show resolved Hide resolved
rows_test.go Outdated Show resolved Hide resolved
statement_test.go Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Nov 30, 2023 •
edited
Loading

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (ceea09f) 82.80% compared to head (e366b87) 82.80%.
Report is 1 commits behind head on master.

Files Patch % Lines
result.go 33.33% 4 Missing ⚠️
connection_util.go 75.00% 2 Missing ⚠️
statement.go 85.71% 2 Missing ⚠️
retry.go 96.55% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #978   +/-   ##
=======================================
  Coverage   82.80%   82.80%           
=======================================
  Files          50       50           
  Lines        9643     9684   +41     
=======================================
+ Hits         7985     8019   +34     
- Misses       1658     1665    +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sfc-gh-pfus
sfc-gh-pfus reviewed Dec 4, 2023
View reviewed changes
connection_util.go Outdated Show resolved Hide resolved
statement_test.go Show resolved Hide resolved
@sfc-gh-pfus sfc-gh-pfus merged commit 1341c39 into master Dec 4, 2023
23 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-978164 branch December 4, 2023 15:12
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pfus sfc-gh-pfus sfc-gh-pfus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-pbulawa @sfc-gh-pfus