Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-961482 Change OCSP response cache key to base64 encoded certID #969

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

sfc-gh-dheyman
Copy link
Collaborator

Description

Please explain the changes you made here.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (25d3956) 82.79% compared to head (4b53e47) 82.78%.
Report is 1 commits behind head on master.

Files Patch % Lines
ocsp.go 82.60% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #969      +/-   ##
==========================================
- Coverage   82.79%   82.78%   -0.01%     
==========================================
  Files          50       50              
  Lines        9625     9633       +8     
==========================================
+ Hits         7969     7975       +6     
- Misses       1656     1658       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-dheyman sfc-gh-dheyman changed the title SNOW-961482 Change OCSP response cache key to serial number SNOW-961482 Change OCSP response cache key to base64 encoded certID Nov 17, 2023
@sfc-gh-dheyman sfc-gh-dheyman force-pushed the SNOW-961482-ocsp-cache-fix branch from b894e19 to 492089f Compare November 17, 2023 12:32
@sfc-gh-dheyman sfc-gh-dheyman marked this pull request as ready for review November 22, 2023 08:33
@sfc-gh-dheyman sfc-gh-dheyman requested a review from a team as a code owner November 22, 2023 08:33
@sfc-gh-dheyman sfc-gh-dheyman merged commit 5c79db8 into master Nov 22, 2023
21 of 23 checks passed
@sfc-gh-dheyman sfc-gh-dheyman deleted the SNOW-961482-ocsp-cache-fix branch November 22, 2023 10:19
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants