SNOW-921006 Introduce wiremock #1300
Open
+330
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-pfus
force-pushed
the
SNOW-921006-wiremock
branch
2 times, most recently
from
f17ab6d to
575b51d
Compare
sfc-gh-mkubik
approved these changes
Feb 10, 2025
.github/workflows/build-test.yml
Outdated
| @@ -26,8 +26,6 @@ concurrency: | |||
| jobs: | |||
| lint: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| fail-fast: false | |||
There was a problem hiding this comment.
Actually, you are right. I misunderstood this section. Good catch!
sfc-gh-pfus
force-pushed
the
SNOW-921006-wiremock
branch
from
575b51d to
d6216ca
Compare
sfc-gh-pfus
force-pushed
the
SNOW-921006-wiremock
branch
from
d6216ca to
a510b4e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1300 +/- ##
==========================================
+ Coverage 82.16% 82.19% +0.02%
==========================================
Files 55 55
Lines 13634 13634
==========================================
+ Hits 11203 11206 +3
+ Misses 2431 2428 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
The name of this file suggests that we are testing wiremock, but I assume that this is a base utility class for tests that use wiremock, right?
| func newWiremock() *wiremockClient { | ||
| return &wiremockClient{ | ||
| host: "127.0.0.1", | ||
| port: 14355, |
There was a problem hiding this comment.
perhaps it would be better to pass this as an ENV VAR in test scripsts?
sfc-gh-dheyman
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SNOW-921006 Introduce wiremock
Checklist