SNOW-1825476 Implement programmatic access token (PAT) #1298
+666
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-pfus
force-pushed
the
SNOW-1825476-pat
branch
12 times, most recently
from
8c3e25f to
23bd952
Compare
sfc-gh-pfus
force-pushed
the
SNOW-1825476-pat
branch
8 times, most recently
from
fa0c6a4 to
0e3f6c4
Compare
sfc-gh-dheyman
approved these changes
Feb 4, 2025
sfc-gh-pfus
force-pushed
the
SNOW-1825476-pat
branch
from
0e3f6c4 to
b4261df
Compare
| requestMain.LoginName = sc.cfg.User | ||
| requestMain.Token = sc.cfg.Token | ||
| if sc.cfg.Password != "" && sc.cfg.Token == "" { | ||
| requestMain.Token = sc.cfg.Password |
There was a problem hiding this comment.
Is it validated that one of the parameters {token password} is not empty?
There was a problem hiding this comment.
Yes, it is validated on wiremock.
There was a problem hiding this comment.
It is possible to fail faster :), during validation.
There was a problem hiding this comment.
Ok, right, done.
sfc-gh-pfus
force-pushed
the
SNOW-1825476-pat
branch
from
b4261df to
ffeefdb
Compare
sfc-gh-pfus
force-pushed
the
SNOW-1825476-pat
branch
from
ffeefdb to
d93d803
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SNOW-1825476 Implemented PAT/programmatic access token support.
Checklist