SNOW-1854657 Fallback to rows parser if JSON returned while in Arrow batches mode #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-pfus
force-pushed
the
SNOW-1854657-arrow-batches-to-rows
branch
from
686d07d to
116e016
Compare
sfc-gh-pfus
force-pushed
the
SNOW-1854657-arrow-batches-to-rows
branch
from
116e016 to
2b6a3e2
Compare
sfc-gh-pfus
changed the title
sfc-gh-dprzybysz
approved these changes
Jan 29, 2025
sfc-gh-pbulawa
approved these changes
Jan 29, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1291 +/- ##
==========================================
- Coverage 82.28% 82.27% -0.01%
==========================================
Files 55 55
Lines 13596 13600 +4
==========================================
+ Hits 11187 11190 +3
- Misses 2409 2410 +1 ☔ View full report in Codecov by Sentry. |
sfc-gh-dheyman
approved these changes
Jan 29, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SNOW-1854657 When Arrow batches mode was enabled but server returned JSON, JSON was not parsed. This PR changes this behaviour to parse rows in that case.
Checklist