Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-991467: Fix retry backoff period for non-auth requests #1051

Merged
merged 6 commits into from
Mar 5, 2024

Conversation

sfc-gh-ext-simba-jl
Copy link
Collaborator

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl commented Feb 15, 2024

Description

issue 804: https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/804

This PR fixes the retry backoff period for query requests.

  • changed the base wait time from 5s to 1s
  • changed the max wait time from 160s 16s
  • The implementation now matches the JDBC driver's decorrelated jitter

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (2f77595) to head (f4dd863).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1051      +/-   ##
==========================================
- Coverage   84.12%   83.98%   -0.14%     
==========================================
  Files          50       50              
  Lines        9889     9918      +29     
==========================================
+ Hits         8319     8330      +11     
- Misses       1570     1588      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl marked this pull request as ready for review February 20, 2024 01:35
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl requested a review from a team as a code owner February 20, 2024 01:35
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl force-pushed the SNOW-991467-retry-backoff branch 2 times, most recently from 6a957b9 to c0c922f Compare February 27, 2024 21:59
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl force-pushed the SNOW-991467-retry-backoff branch from c0c922f to f4dd863 Compare March 4, 2024 18:06
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl merged commit dfc06ac into master Mar 5, 2024
33 of 34 checks passed
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl deleted the SNOW-991467-retry-backoff branch March 5, 2024 00:19
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants