-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-969719: Increased max LOB size complete testing #1047
Merged
sfc-gh-ext-simba-jl
merged 11 commits into
master
from
SNOW-969719-IncreasedMaxLOBSizeTest
Feb 13, 2024
Merged
SNOW-969719: Increased max LOB size complete testing #1047
sfc-gh-ext-simba-jl
merged 11 commits into
master
from
SNOW-969719-IncreasedMaxLOBSizeTest
Feb 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1047 +/- ##
==========================================
- Coverage 84.17% 84.16% -0.02%
==========================================
Files 50 50
Lines 9878 9878
==========================================
- Hits 8315 8314 -1
- Misses 1563 1564 +1 ☔ View full report in Codecov by Sentry. |
360703b
to
91eac86
Compare
sfc-gh-dheyman
approved these changes
Feb 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
issue 747: https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/747
Add tests for increased LOB size.
Increase timeout from 30m to 50m because generating large string takes significant time.
Checklist
make fmt
to fix inconsistent formatsmake lint
to get lint errors and fix all of them