Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-969719: Increased max LOB size complete testing #1047

Merged
merged 11 commits into from
Feb 13, 2024

Conversation

sfc-gh-ext-simba-jl
Copy link
Collaborator

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl commented Feb 6, 2024

Description

issue 747: https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/747
Add tests for increased LOB size.
Increase timeout from 30m to 50m because generating large string takes significant time.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (400b315) 84.17% compared to head (91eac86) 84.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1047      +/-   ##
==========================================
- Coverage   84.17%   84.16%   -0.02%     
==========================================
  Files          50       50              
  Lines        9878     9878              
==========================================
- Hits         8315     8314       -1     
- Misses       1563     1564       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl force-pushed the SNOW-969719-IncreasedMaxLOBSizeTest branch from 360703b to 91eac86 Compare February 9, 2024 00:14
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl marked this pull request as ready for review February 9, 2024 03:19
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl requested a review from a team as a code owner February 9, 2024 03:19
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl merged commit bd9aa25 into master Feb 13, 2024
31 of 32 checks passed
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl deleted the SNOW-969719-IncreasedMaxLOBSizeTest branch February 13, 2024 19:38
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants