Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-911238 Add doc about WithOriginalTimestamp #1040

Merged
merged 1 commit into from
Jan 26, 2024
Merged

SNOW-911238 Add doc about WithOriginalTimestamp #1040

merged 1 commit into from
Jan 26, 2024

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Jan 25, 2024 •
edited
Loading

Description

Added docs about the feature introduced in SNOW-911238.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review January 25, 2024 13:06
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner January 25, 2024 13:06
@codecov Codecov
Copy link

codecov bot commented Jan 25, 2024 •
edited
Loading

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (7b3319d) 83.14% compared to head (805c29b) 84.07%.
Report is 1 commits behind head on master.

Files Patch % Lines
easy_logging.go 58.97% 16 Missing ⚠️
client_configuration.go 82.08% 12 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1040      +/-   ##
==========================================
+ Coverage   83.14%   84.07%   +0.93%     
==========================================
  Files          50       50              
  Lines        9759     9841      +82     
==========================================
+ Hits         8114     8274     +160     
+ Misses       1645     1567      -78

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-911238-add-doc-with-original-timestamp branch from 5b8feae to fd5739b Compare January 26, 2024 06:59
sfc-gh-mheavin
sfc-gh-mheavin reviewed Jan 26, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-mheavin sfc-gh-mheavin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions and questions

doc.go Outdated Show resolved Hide resolved
doc.go Outdated Show resolved Hide resolved
doc.go Outdated Show resolved Hide resolved
doc.go Show resolved Hide resolved
doc.go Outdated Show resolved Hide resolved
doc.go Outdated Show resolved Hide resolved
doc.go Outdated Show resolved Hide resolved
doc.go Outdated Show resolved Hide resolved
doc.go Outdated Show resolved Hide resolved
doc.go Outdated Show resolved Hide resolved
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-911238-add-doc-with-original-timestamp branch from fd5739b to 7958dec Compare January 26, 2024 14:08
sfc-gh-mheavin
sfc-gh-mheavin approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-mheavin sfc-gh-mheavin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

responded to your questions

doc.go Outdated Show resolved Hide resolved
doc.go Outdated Show resolved Hide resolved
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-911238-add-doc-with-original-timestamp branch from 7958dec to 937375c Compare January 26, 2024 15:40
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-911238-add-doc-with-original-timestamp branch from 937375c to 805c29b Compare January 26, 2024 17:08
@sfc-gh-pfus sfc-gh-pfus merged commit 385c856 into master Jan 26, 2024
33 of 34 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-911238-add-doc-with-original-timestamp branch January 26, 2024 20:47
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-mheavin sfc-gh-mheavin sfc-gh-mheavin approved these changes

@sfc-gh-dstempniak sfc-gh-dstempniak sfc-gh-dstempniak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-pfus @sfc-gh-mheavin @sfc-gh-dstempniak