Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-916951: Retry okta auth with new token #1032

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

sfc-gh-ext-simba-jl
Copy link
Collaborator

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl commented Jan 17, 2024

Description

issue: https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/655

The native Okta Authentication fails in retry due to the same token is used in an sso/saml retry.
This PR fixes the retry logic by generating a new token each time it retries.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5c89d42) 83.14% compared to head (946a1d4) 83.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1032      +/-   ##
==========================================
- Coverage   83.14%   83.12%   -0.03%     
==========================================
  Files          50       50              
  Lines        9761     9759       -2     
==========================================
- Hits         8116     8112       -4     
- Misses       1645     1647       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl marked this pull request as ready for review January 18, 2024 16:38
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl requested a review from a team as a code owner January 18, 2024 16:38
auth.go Show resolved Hide resolved
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl merged commit 611fe9d into master Jan 24, 2024
33 of 34 checks passed
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl deleted the 655-OktaRetryHttp429 branch January 24, 2024 22:45
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants