Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-999076: Easy Logging fixes #1030

Merged
merged 14 commits into from
Jan 26, 2024
Merged

SNOW-999076: Easy Logging fixes #1030

merged 14 commits into from
Jan 26, 2024

Conversation

sfc-gh-pbulawa
Copy link
Collaborator

@sfc-gh-pbulawa sfc-gh-pbulawa commented Jan 11, 2024 •
edited
Loading

Description

Fix Easy Logging

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-pbulawa sfc-gh-pbulawa requested a review from a team as a code owner January 11, 2024 14:11
@codecov Codecov
Copy link

codecov bot commented Jan 11, 2024 •
edited
Loading

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (7b3319d) 83.14% compared to head (238abbc) 84.07%.

Files Patch % Lines
easy_logging.go 58.97% 16 Missing ⚠️
client_configuration.go 82.08% 12 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1030      +/-   ##
==========================================
+ Coverage   83.14%   84.07%   +0.93%     
==========================================
  Files          50       50              
  Lines        9759     9841      +82     
==========================================
+ Hits         8114     8274     +160     
+ Misses       1645     1567      -78

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pbulawa sfc-gh-pbulawa force-pushed the SNOW-999076-easy-logging branch from 8a1532d to 14c86c5 Compare January 11, 2024 15:33
sfc-gh-knozderko
sfc-gh-knozderko requested changes Jan 11, 2024
View reviewed changes
client_configuration.go Outdated Show resolved Hide resolved
client_configuration.go Outdated Show resolved Hide resolved
client_configuration.go Outdated Show resolved Hide resolved
client_configuration.go Outdated Show resolved Hide resolved
client_configuration.go Outdated Show resolved Hide resolved
client_configuration.go Outdated Show resolved Hide resolved
client_configuration_test.go Outdated Show resolved Hide resolved
sfc-gh-pfus
sfc-gh-pfus reviewed Jan 12, 2024
View reviewed changes
client_configuration.go Outdated Show resolved Hide resolved
client_configuration.go Outdated Show resolved Hide resolved
client_configuration.go Outdated Show resolved Hide resolved
sfc-gh-knozderko
sfc-gh-knozderko requested changes Jan 12, 2024
View reviewed changes
client_configuration.go Outdated Show resolved Hide resolved
client_configuration.go Outdated Show resolved Hide resolved
client_configuration.go Outdated Show resolved Hide resolved
client_configuration.go Show resolved Hide resolved
client_configuration.go Outdated Show resolved Hide resolved
client_configuration.go Outdated Show resolved Hide resolved
sfc-gh-knozderko
sfc-gh-knozderko reviewed Jan 17, 2024
View reviewed changes
client_configuration.go Outdated Show resolved Hide resolved
easy_logging_test.go Outdated Show resolved Hide resolved
easy_logging_test.go Outdated Show resolved Hide resolved
@sfc-gh-pbulawa sfc-gh-pbulawa merged commit d63ec27 into master Jan 26, 2024
33 of 34 checks passed
@sfc-gh-pbulawa sfc-gh-pbulawa deleted the SNOW-999076-easy-logging branch January 26, 2024 13:36
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-knozderko sfc-gh-knozderko sfc-gh-knozderko approved these changes

@sfc-gh-pfus sfc-gh-pfus Awaiting requested review from sfc-gh-pfus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-pbulawa @sfc-gh-knozderko @sfc-gh-pfus