-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-955538: Multiple SAML Integrations Support #1025
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1025 +/- ##
==========================================
+ Coverage 82.79% 83.12% +0.33%
==========================================
Files 50 50
Lines 9718 9761 +43
==========================================
+ Hits 8046 8114 +68
+ Misses 1672 1647 -25 ☔ View full report in Codecov by Sentry. |
d474a65
to
193d6fe
Compare
Tests performed, similar to https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/580#issuecomment-1875240051: Connect to the new SF (with multiple SAML support), regardless of disableConsoleLogin:
Connect to the old SF (without multiple SAML support and single IdP defined): when disableConsoleLogin not specified or disableConsoleLogin=true:
when disableConsoleLogin=false:
|
cca9f34
to
15cf605
Compare
15cf605
to
76551a5
Compare
Description
Issue: https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/726
Checklist
make fmt
to fix inconsistent formatsmake lint
to get lint errors and fix all of them