Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-955538: Multiple SAML Integrations Support #1025

Merged
merged 17 commits into from
Jan 15, 2024

Conversation

sfc-gh-ext-simba-jl
Copy link
Collaborator

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl commented Jan 9, 2024

Description

Issue: https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/726

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (72af178) 82.79% compared to head (3092e5b) 83.12%.
Report is 2 commits behind head on master.

Files Patch % Lines
authexternalbrowser.go 78.57% 6 Missing ⚠️
async.go 93.33% 3 Missing ⚠️
dsn.go 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1025      +/-   ##
==========================================
+ Coverage   82.79%   83.12%   +0.33%     
==========================================
  Files          50       50              
  Lines        9718     9761      +43     
==========================================
+ Hits         8046     8114      +68     
+ Misses       1672     1647      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl marked this pull request as ready for review January 9, 2024 08:08
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl requested a review from a team as a code owner January 9, 2024 08:08
@sfc-gh-pfus
Copy link
Collaborator

Tests performed, similar to https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/580#issuecomment-1875240051:

Connect to the new SF (with multiple SAML support), regardless of disableConsoleLogin:

  • redirects to the browser with a list with multiple SSO providers
  • login completed successfully

Connect to the old SF (without multiple SAML support and single IdP defined):

when disableConsoleLogin not specified or disableConsoleLogin=true:

  • redirects to single SSO provider defined in SF
  • login completed successfully

when disableConsoleLogin=false:

  • redirects to UI console
  • not logged as expected

doc.go Outdated Show resolved Hide resolved
dsn_test.go Outdated Show resolved Hide resolved
auth_test.go Outdated Show resolved Hide resolved
authexternalbrowser.go Outdated Show resolved Hide resolved
authexternalbrowser.go Outdated Show resolved Hide resolved
doc.go Outdated Show resolved Hide resolved
dsn_test.go Outdated Show resolved Hide resolved
dsn_test.go Outdated Show resolved Hide resolved
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl merged commit 5c89d42 into master Jan 15, 2024
34 checks passed
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl deleted the 726-multipleSAML branch January 15, 2024 23:59
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants