-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-942595: Retry the fetch result request for response code queryInProgressAsyncCode when using WithFetchResultByID #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53c7c07
to
2598c50
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1021 +/- ##
==========================================
+ Coverage 82.79% 82.89% +0.09%
==========================================
Files 50 50
Lines 9718 9721 +3
==========================================
+ Hits 8046 8058 +12
+ Misses 1672 1663 -9 ☔ View full report in Codecov by Sentry. |
2598c50
to
2a7c7ff
Compare
sfc-gh-pfus
reviewed
Jan 9, 2024
sfc-gh-pfus
reviewed
Jan 10, 2024
sfc-gh-pfus
reviewed
Jan 11, 2024
6d54e29
to
3ab334b
Compare
sfc-gh-pfus
approved these changes
Jan 15, 2024
…e doc.go and add fetchresultbyid example
3ab334b
to
4f93e57
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
issue: #705
using:
will return no error and no result after about 45 seconds.
This PR applies the same change as PR #824 to check for the status
queryInProgressAsyncCode
inrowsForRunningQuery
inmonitoring.go
Checklist
make fmt
to fix inconsistent formatsmake lint
to get lint errors and fix all of them