Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-942595: Retry the fetch result request for response code queryInProgressAsyncCode when using WithFetchResultByID #1021

Merged
merged 6 commits into from
Jan 15, 2024

Conversation

sfc-gh-ext-simba-jl
Copy link
Collaborator

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl commented Jan 8, 2024

Description

issue: #705
using:

ctx = gosnowflake.WithFetchResultByID(ctx, queryId)
rows, err := s.db.QueryContext(ctx, "")

will return no error and no result after about 45 seconds.

This PR applies the same change as PR #824 to check for the status queryInProgressAsyncCode in rowsForRunningQuery in monitoring.go

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (72af178) 82.79% compared to head (4f93e57) 82.89%.
Report is 1 commits behind head on master.

Files Patch % Lines
async.go 93.33% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1021      +/-   ##
==========================================
+ Coverage   82.79%   82.89%   +0.09%     
==========================================
  Files          50       50              
  Lines        9718     9721       +3     
==========================================
+ Hits         8046     8058      +12     
+ Misses       1672     1663       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl marked this pull request as ready for review January 9, 2024 02:08
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl requested a review from a team as a code owner January 9, 2024 02:08
async_test.go Outdated Show resolved Hide resolved
async_test.go Show resolved Hide resolved
async_test.go Outdated Show resolved Hide resolved
async_test.go Outdated Show resolved Hide resolved
async_test.go Outdated Show resolved Hide resolved
async_test.go Outdated Show resolved Hide resolved
async_test.go Outdated Show resolved Hide resolved
async_test.go Outdated Show resolved Hide resolved
monitoring.go Outdated Show resolved Hide resolved
monitoring.go Outdated Show resolved Hide resolved
async.go Outdated Show resolved Hide resolved
async.go Show resolved Hide resolved
async_test.go Outdated Show resolved Hide resolved
cmd/fetchresultbyid/fetchresultbyid.go Outdated Show resolved Hide resolved
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl merged commit f1dfe51 into master Jan 15, 2024
34 checks passed
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl deleted the 705-WithFetchResultByID branch January 15, 2024 19:37
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants