Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-996678 Use snowflakeTransport for all clouds #1018

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Dec 22, 2023

Description

Use the same transport configuration for all stages.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-996678-snowflake-transport branch from 05f5877 to 7d23fa4 Compare December 22, 2023 13:55
@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review December 22, 2023 13:55
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner December 22, 2023 13:55
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f1d625f) 82.80% compared to head (7164d96) 82.84%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1018      +/-   ##
==========================================
+ Coverage   82.80%   82.84%   +0.04%     
==========================================
  Files          50       50              
  Lines        9711     9718       +7     
==========================================
+ Hits         8041     8051      +10     
+ Misses       1670     1667       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-996678-snowflake-transport branch from 7d23fa4 to 7164d96 Compare January 8, 2024 11:47
@sfc-gh-pfus sfc-gh-pfus merged commit 146dd7a into master Jan 8, 2024
34 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-996678-snowflake-transport branch January 8, 2024 13:04
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants