Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-991467 Remove 400 & 405 statuses from retry #1007

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

sfc-gh-dheyman
Copy link
Collaborator

@sfc-gh-dheyman sfc-gh-dheyman commented Dec 14, 2023

Description

This change excludes statuses 400 & 405 from retry strategy as these should not be retried.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-dheyman sfc-gh-dheyman requested a review from a team as a code owner December 14, 2023 11:02
@sfc-gh-pbulawa
Copy link
Collaborator

Could you add a description please?

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (31d7dc2) 82.83% compared to head (6823d27) 82.83%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1007   +/-   ##
=======================================
  Coverage   82.83%   82.83%           
=======================================
  Files          50       50           
  Lines        9698     9698           
=======================================
  Hits         8033     8033           
  Misses       1665     1665           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-dheyman sfc-gh-dheyman merged commit e49463c into master Dec 15, 2023
23 checks passed
@sfc-gh-dheyman sfc-gh-dheyman deleted the SNOW-991467-retry-strategy-bug branch December 15, 2023 07:57
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants