Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-925280 Drop go 1.19 support, add 1.21 support #1003

Closed
wants to merge 1 commit into from

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Dec 13, 2023

Description

Dropped support for unsupported Golan 1.19, added support for current 1.21 version.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-925280-go-version branch from 6e9b895 to 02223f7 Compare December 13, 2023 13:14
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (31d7dc2) 82.83% compared to head (9e02ad1) 82.83%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1003   +/-   ##
=======================================
  Coverage   82.83%   82.83%           
=======================================
  Files          50       50           
  Lines        9698     9698           
=======================================
  Hits         8033     8033           
  Misses       1665     1665           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-925280-go-version branch from 02223f7 to 78f2a4e Compare December 14, 2023 06:35
@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review December 14, 2023 07:09
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner December 14, 2023 07:09
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-925280-go-version branch 2 times, most recently from 95f0802 to 3d50ab6 Compare December 14, 2023 07:49
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-925280-go-version branch from 3d50ab6 to 9e02ad1 Compare December 14, 2023 08:15
@ChronosMasterOfAllTime
Copy link
Contributor

@sfc-gh-pfus may as well bump this to 1.22

@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-925280-go-version branch June 27, 2024 12:33
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants