Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-ext-simba-jy committed Dec 19, 2024
1 parent 0790f08 commit 67139c1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion gcs_storage_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -411,8 +411,9 @@ func newGcsClient() gcsAPI {
}

func getGcsCustomEndpoint(info *execResponseStageInfo) string {
// TODO: SNOW-1789759 hardcoded region will be replaced in the future
endpoint := "https://storage.googleapis.com"

// TODO: SNOW-1789759 hardcoded region will be replaced in the future
isRegionalURLEnabled := (strings.ToLower(info.Region) == gcsRegionMeCentral2) || info.UseRegionalURL
if info.EndPoint != "" {
endpoint = fmt.Sprintf("https://%s", info.EndPoint)
Expand Down
2 changes: 1 addition & 1 deletion gcs_storage_client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1136,7 +1136,7 @@ func TestGetGcsCustomEndpoint(t *testing.T) {
out string
}{
{
desc: "when both the endPoint is not specified and UseRegionalURL is false",
desc: "when the endPoint is not specified and UseRegionalURL is false",
in: execResponseStageInfo{
UseRegionalURL: false,
EndPoint: "",
Expand Down

0 comments on commit 67139c1

Please sign in to comment.