-
Notifications
You must be signed in to change notification settings - Fork 757
feat: Add online installer and auto-config for autoHandoff #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Adds an install.sh script for easy installation with curl. The script also automatically configures the recommended amp.experimental.autoHandoff setting in the user's ~/.config/amp/settings.json file. Co-Authored-By: Claude <[email protected]>
af64da3 to
45d8cd1
Compare
|
Thanks @jellydn - can you share a video of you using this and verifying it works? |
|
@snarktank Sure, here you are: https://s.itman.fyi/G0bNBgJJ |
|
Hey, thanks so much for putting this together! Really appreciate you taking the time to contribute. I love the idea of making installation easier, but I have some security concerns with the curl | bash pattern that I'm not comfortable shipping:
These are industry-wide concerns with this pattern, not anything specific to your implementation. Would you be open to reworking this to either:
Totally understand if you don't have time for that - just wanted to explain why I can't merge as-is. Thanks again for trying to improve the repo. |
|
Hi, I see your point and here is the plan Are you okay with this approach? Thanks. |
|
FYI - Tested on https://github.com/jellydn/ralph/releases/tag/v1.0.0-beta.1 |
|
Thanks for putting together this plan and testing it! This looks good to me. One small request before I merge: can you add a download-verify-run option to the README alongside the curl | bash? Something like: # Or download and inspect first
curl -O https://github.com/snarktank/ralph/releases/latest/download/install-from-release.sh
less install-from-release.sh # inspect
bash install-from-release.sh
That way users who want to verify before running have a clear path. Once that's in, I'll merge. |
Add installation section to README with options to: - Quick install from latest release via curl pipe - Download and inspect script before running for security - Install specific version by setting VERSION environment variable This provides users with flexible installation methods and follows security best practices by offering script inspection option.
|
Sure @snarktank No problem, thanks. |
What
This PR introduces an online installer script to simplify the setup of Ralph. It also enables the installer to automatically configure the recommended setting for users.
Why
How
Run the installer script:
curl -sSL https://raw.githubusercontent.com/jellydn/ralph/feature/online-installer/install.sh | bash