-
Notifications
You must be signed in to change notification settings - Fork 724
Add Claude Code support #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add --tool flag to ralph.sh (amp|claude, defaults to amp)
- Update documentation in README.md and AGENTS.md
- Update flowchart to be tool-agnostic ("AI picks a story" vs "Amp picks a story")
- Add .claude/ to .gitignore
Usage: ./ralph.sh --tool claude [max_iterations]
|
I've ported it to Claude Code: https://github.com/wquguru/ralph-ryan
|
|
Thanks - i guess up to @snarktank if he wants support for both or not in a single tool. I wont be offended personally if the answer is no, i have it working on my personal fork as well, i figured i would at least submit the PR out of good faith |
|
Hi @denen99 - thanks for submitting. Your claude prompt should use CLAUDE.md because that's what it uses. Please fix and I'll look at this again. |
used CLAUDE.md
|
my fault, i didnt realize prompt.md was native to AMP instead of ralph, apologies. I updated the PR to use CLAUDE.md as well as the necessary docs. Also apologies for the dupe PR, github defaults to the remote PR when creating pull requests instead of local which created an extra PR by accident. |
|
Thanks @denen99. I'd appreciate it if you could run 2+ loops with this new implementation and report back. I want to triple check it really works well. Please test it in both CC and Amp. Thanks! |
|
@snarktank ran 2 clean tests, 1 with claude, 1 with amp, each with an initial PRD and a follow up PRD in existing directory. There was one small bug in ralph.sh that I addressed and updated in the PR, after that both runs worked without issue. Claude Run - https://gist.github.com/denen99/8d0b545c82af096cebc807a6bcdd3823 Amp Run - https://gist.github.com/denen99/87ecb0d4950dc0e3023da2ddaf89517f |
| cp -r skills/ralph ~/.claude/skills/ | ||
| ``` | ||
|
|
||
| ### Configure Amp auto-handoff (recommended) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey, i think the command for claude should also be added in this section as well if it's being added for other things.
Claude Code: claude --dangerously-skip-permissions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure i follow, claude does run with --dangerously-skip-permissions in ralph.sh line 95
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm my bad, i mistook auto handoff for something else.
|
@denen99 Thanks. I'll probably merge this but first please close any other dupe PRs (if there are any). I need time to look a little more closely at the code. |
|
scripts/ralph/CLAUDE.md instructions still mention AGENTS.md everywhere instead of CLAUDE.md.. fyi |
|
Thanks for the thorough testing. Ready to merge once you fix the issue @archvalmiki flagged - CLAUDE.md still references AGENTS.md in a few places. Please update those references to CLAUDE.md and I'll merge. |
|
Thanks @archvalmiki for the spot, missed that. CLAUDE.md has been updated @snarktank |
|
I don't think this type of if/else implementation is great, it will get messy when we want to add opencode, copilot, gemini, codex, etc. How about a config file (eg yml/json) that is read from with amp as the default. it can have the tool name, prompt, list of any env vars, cli command to run, etc. And instead of mostly copying the prompt we could have a prompt template and jinja or other templating to render the prompt based on the config selected |
|
if this isnt merged i think i will start using https://github.com/frizynn/gralph |
No description provided.