iface: act on ICMP destination-unreachable hard errors for TCP - #1200
Open
sigvartmh wants to merge 2 commits into
Open
iface: act on ICMP destination-unreachable hard errors for TCP #1200sigvartmh wants to merge 2 commits into
sigvartmh wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1200 +/- ##
==========================================
+ Coverage 82.57% 82.75% +0.17%
==========================================
Files 83 83
Lines 26174 26250 +76
==========================================
+ Hits 21613 21722 +109
+ Misses 4561 4528 -33 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sigvartmh
force-pushed
the
fix/icmp-fixmes
branch
from
August 19, 2026 09:51
267adbe to
4d0c95f
Compare
Add tests to confirm that we don't adhere to RFC 1122 §4.2.3.9 and RFC 5461 §4.
`process_icmpv4` and `process_icmpv6` parse Destination Unreachable in full, including the transport header quoted inside it, and then drop the result at. A `connect()` to a host that explicitly refuses therefore waits out the whole retransmission budget instead of failing when the refusal arrives. Per RFC 1122 §4.2.3.9 and RFC 5461 §4 only hard errors act. Transient codes are ignored, `FragRequired` stays a soft error. Path MTU Discovery remains unimplemented: it needs a per-destination MTU cache that does not exist in the stack. Left a `FIXME` for the remaining unhandled errors.
sigvartmh
force-pushed
the
fix/icmp-fixmes
branch
from
August 19, 2026 12:37
4d0c95f to
a9b0e68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
process_icmpv4andprocess_icmpv6parse Destination Unreachable infull, including the transport header quoted inside it, and then drop the
result at. A
connect()to a host that explicitly refuses thereforewaits out the whole retransmission budget instead of failing when the
refusal arrives.
Per RFC 1122 §4.2.3.9 and RFC 5461 §4 only hard errors act. Transient
codes are ignored,
FragRequiredstays a soft error.Path MTU Discovery remains unimplemented: it needs a per-destination MTU
cache that does not exist in the stack.
Left a
FIXMEfor the remaining unhandled errors.