Skip to content

port to qnx #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2025
Merged

port to qnx #201

merged 2 commits into from
Apr 29, 2025

Conversation

dantunan
Copy link
Contributor

@dantunan dantunan commented May 3, 2024

No description provided.

@notgull
Copy link
Member

notgull commented May 3, 2024

@taiki-e Is this failure a result of the cross tool chain action?

Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR tested on the actual OS?

@taiki-e
Copy link
Collaborator

taiki-e commented May 3, 2024

@taiki-e Is this failure a result of the cross tool chain action?

Rust 1.78 contains changes that cause compatibility issues with older wine/mingw toolchains. (e.g., rust-lang/rust#123999 rust-lang/rust#122228)
Removing the following line and using the latest stable Wine version that is used by default by setup-cross-toolchain-action should fix the problem.

notgull added a commit that referenced this pull request May 4, 2024
This works around bugs in Rust v1.78 that introduce incompatibilities
into Wine.

#201 (comment)

Signed-off-by: John Nunley <[email protected]>
notgull added a commit that referenced this pull request May 4, 2024
This works around bugs in Rust v1.78 that introduce incompatibilities
into Wine.

#201 (comment)

Signed-off-by: John Nunley <[email protected]>
@notgull
Copy link
Member

notgull commented May 19, 2024

Hello @dantunan! Just wanted to check in.

Is this PR tested on the actual QNX operating system? If so I would be happy to merge it.

@luyangliu616
Copy link

if you do not merge it

error[E0432]: unresolved import `rustix::pipe::pipe_with`
   --> src/poll.rs:639:9
    |
639 |     use rustix::pipe::pipe_with;
    |         ^^^^^^^^^^^^^^^^^^^^^^^ no `pipe_with` in `pipe`
    |
note: found an item that was configured out
   --> /home/pp/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rustix-0.38.44/src/pipe.rs:108:8
    |
108 | pub fn pipe_with(flags: PipeFlags) -> io::Result<(OwnedFd, OwnedFd)> {
    |        ^^^^^^^^^
note: the item is gated here
   --> /home/pp/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rustix-0.38.44/src/pipe.rs:99:1
    |
99  | / #[cfg(not(any(
100 | |     apple,
101 | |     target_os = "aix",
102 | |     target_os = "espidf",
103 | |     target_os = "haiku",
104 | |     target_os = "nto"
105 | | )))]
    | |____^

@fogti fogti merged commit c066873 into smol-rs:master Apr 29, 2025
26 checks passed
@fogti fogti mentioned this pull request Apr 29, 2025
@taiki-e
Copy link
Collaborator

taiki-e commented May 25, 2025

Published in 3.8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants