Skip to content

v2.0.0 #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2022
Merged

v2.0.0 #29

merged 1 commit into from
Nov 8, 2022

Conversation

notgull
Copy link
Member

@notgull notgull commented Nov 6, 2022

Changes:

@fogti
Copy link
Member

fogti commented Nov 6, 2022

"adding an std feature" is only a breaking change because crates can opt to default-features = false, right?

@notgull
Copy link
Member Author

notgull commented Nov 6, 2022

"adding an std feature" is only a breaking change because crates can opt to default-features = false, right?

Yes. With the std feature, certain traits that are normally implemented on concurrent-queue are disabled. There is a way around it (see #29), but it's probably better to just go with the breaking change.

@fogti
Copy link
Member

fogti commented Nov 7, 2022

I'm not sure if we should release a new version yet, or check if downstream crates might need some additional modifications...

@notgull
Copy link
Member Author

notgull commented Nov 7, 2022

All of smol's crates do not use concurrent-queue as a public dependency. smol is by and large the largest user of concurrent-queue; all of its crates have about 10 million downloads, while the next largest consumer (jackiechan) has about 50k downloads. Of the crates with more than 10k downloads:

None of these crates have concurrent-queue as a public dependency. Every other crate involved has less than 10k downloads.

Cargo.toml Outdated
Comment on lines 7 to 12
authors = ["Stjepan Glavina <[email protected]>"]
edition = "2018"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe update authors. We can't update edition due to the would-be-implied msrv bump

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added myself and @taiki-e to the authors list, since the GitHub contributors tab shows that we are the main contributors to this crate.

@notgull notgull merged commit 3d653aa into master Nov 8, 2022
@notgull notgull deleted the 2.0.0 branch November 8, 2022 22:59
@notgull
Copy link
Member Author

notgull commented Nov 9, 2022

@smol-rs/admins It looks like I don't have push permissions, so the release didn't take. Does anyone mind making the push?

@taiki-e
Copy link
Collaborator

taiki-e commented Nov 9, 2022

Published. Thanks for working on this!

(In the future I would like to set up CI to publish the crate via tag push like my crates.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants