Skip to content

feat: big number support for cbor #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented May 22, 2025

reference:
https://www.rfc-editor.org/rfc/rfc8949.html#name-bignums
https://www.rfc-editor.org/rfc/rfc8949.html#name-decimal-fractions-and-bigfl

related: #1511

PR adds support for BigInteger and BigDecimal in the Smithy RPC v2 CBOR protocol.

A new build setting is added called "bigNumberMode":

  • big.js -> use the Big class from big.js for serde
  • native -> uses the native JS bigint class for BigInteger and the @smithy/core/serde NumericValue container class for BigDecimal

@kuhe kuhe force-pushed the feat/numerics branch 5 times, most recently from 010b719 to 776a370 Compare May 27, 2025 20:55
@kuhe kuhe mentioned this pull request May 20, 2025
2 tasks
@kuhe kuhe force-pushed the feat/numerics branch from 776a370 to 31d4161 Compare May 29, 2025 17:41
bigint support in cbor
@kuhe kuhe force-pushed the feat/numerics branch 3 times, most recently from 69b2e1e to a7d5843 Compare June 24, 2025 17:47
@kuhe kuhe marked this pull request as ready for review June 24, 2025 18:06
@kuhe kuhe requested a review from a team as a code owner June 24, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants