Various fixes and updates for aws-smithy-http including errors and impl futures::Stream for SdkBody
#1733
Conversation
add: futures::Stream impl for SdkBody update: use futures-lite instead of futures-core remove: callbacks API for SdkBody and ByteStream remove: Error::source impl for byte_stream::Error update: hyper version
Velfi
changed the title
aws-smithy-http including errors and impl futures::Stream for SdkBody
| @@ -26,7 +26,7 @@ aws-types = { path = "../../sdk/build/aws-sdk/sdk/aws-types" } | |||
| time = { version = "0.3.4", features = ["parsing"] } | |||
| tokio = { version = "1.8.4", features = ["sync"] } | |||
| tracing = { version = "0.1" } | |||
| hyper = { version = "0.14.12", default-features = false } | |||
| hyper = { version = "0.14.20", default-features = false } | |||
There was a problem hiding this comment.
Why was the hyper upgrade necessary?
There was a problem hiding this comment.
It wasn't, I just saw that the server folks were using .20 so I figured I'd update our stuff too. I can remove this if you like.
There was a problem hiding this comment.
Follow the RFC on this: https://awslabs.github.io/smithy-rs/design/rfcs/rfc0021_dependency_versions.html
| Please limit stream length to less than 4.294Gb or run this program on a 64-bit computer architecture. | ||
| "#; | ||
|
|
||
| impl Stream for SdkBody { |
There was a problem hiding this comment.
The reasoning for not doing this up until now was that AsyncIterator was close to becoming stabilized in std, and this will be obsolete as soon as that happens. This is definitely worth discussing further since it looks like that will take longer due to discussion of generic keywords. Maybe we should create another runtime crate similar to aws-smithy-types-convert that adds in useful conversions to the current set of async traits that are widely used until they become std.
There are a couple of crates that need to get revisited as we get closer to a stable release:
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Motivation and Context
I started this because of #1582 but I added more changes.
Description
This fixes several small issues I had with
aws-smithy-httpincluding:add: futures::Stream impl for SdkBody
update: use futures-lite instead of futures-core
remove: callbacks API for SdkBody and ByteStream
remove: Error::source impl for byte_stream::Error
update: hyper version
Testing
wrote 2 tests and ran existing tests
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.