Add system property to allow host header to be added to HttpRequest #766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adwsingh
changed the title
mcp/mcp-cli/src/main/java/software/amazon/smithy/java/mcp/cli/McpCli.java
Outdated
Show resolved
Hide resolved
...cp-cli/src/main/java/software/amazon/smithy/java/mcp/cli/CliSystemPropertiesInitializer.java
Outdated
Show resolved
Hide resolved
|
|
||
| @CommandLine.Command(name = "mcp-registry", versionProvider = VersionProvider.class, mixinStandardHelpOptions = true, | ||
| scope = CommandLine.ScopeType.INHERIT) | ||
| class McpRegistry {} |
There was a problem hiding this comment.
Why did this have to be moved?
There was a problem hiding this comment.
I didn't want any accidental class initialization before we add system properties. The annotations on McpCli were triggering some.
adwsingh
force-pushed
the
adwsingh/system-properties-hook
branch
from
0731e94 to
840b2e1
Compare
adwsingh
changed the title
rhernandez35
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a hook to add system properties to the Cli
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.