Skip to content

Potential fix for code scanning alert no. 5: Server-side request forgery #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Potential fix for code scanning alert no. 5: Server-side request forgery #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions lib/smile-identity-core/web_api.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,7 @@ def zip_up_file(info_json)
end

def upload_file(url, info_json, smile_job_id)
validate_upload_url!(url)
file = zip_up_file(info_json)
file.rewind

Expand All @@ -336,6 +337,20 @@ def upload_file(url, info_json, smile_job_id)
request.run
end

# Validate upload_url against expected host/prefix
def validate_upload_url!(upload_url)
allowed_host = URI.parse(@url).host
begin
uri = URI.parse(upload_url)
rescue URI::InvalidURIError
raise ArgumentError, "Invalid upload_url"
end
# Only allow URLs that match the known host
unless uri.host == allowed_host
raise ArgumentError, "Untrusted upload_url: #{upload_url}"
end
end

def query_job_status(counter = 0)
counter < 4 ? (sleep 2) : (sleep 6)
counter += 1
Expand Down
Loading