Skip to content

Conversation

@tobitech
Copy link
Contributor

@tobitech tobitech commented Nov 3, 2025

User description

Story: https://app.shortcut.com/smileid/story/xxx

Summary

  • Bump iOS SDK Version
  • Bump Pubspec file.

Known Issues

N/A

Test Instructions

N/A

Screenshot

N/A


PR Type

Enhancement


Description

  • Bump iOS SDK dependency from 11.1.1 to 11.1.2

  • Update package version from 11.2.2 to 11.2.3

  • Upgrade CI Xcode version to 16.4 on macOS 15

  • Update minimum iOS version to 13.0 and Xcode project settings


File Walkthrough

Relevant files
Dependencies
2 files
smile_id.podspec
Update SmileID dependency to version 11.1.2                           
+1/-1     
pubspec.yaml
Bump package version to 11.2.3                                                     
+1/-1     
Documentation
1 files
CHANGELOG.md
Add iOS SDK v11.1.2 bump entry                                                     
+1/-0     
Configuration changes
4 files
build.yaml
Update CI to use Xcode 16.4 on macOS 15                                   
+12/-9   
project.pbxproj
Upgrade Xcode project to version 1510                                       
+1/-1     
Runner.xcscheme
Add custom LLDB init file and GPU validation                         
+3/-0     
AppFrameworkInfo.plist
Update minimum iOS version to 13.0                                             
+1/-1     
Enhancement
1 files
AppDelegate.swift
Replace deprecated UIApplicationMain with @main annotation
+1/-1     


Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @tobitech tobitech self-assigned this Nov 3, 2025
    @tobitech tobitech marked this pull request as ready for review November 3, 2025 12:02
    @tobitech tobitech requested a review from a team as a code owner November 3, 2025 12:02
    @prfectionist
    Copy link
    Contributor

    prfectionist bot commented Nov 3, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Breaking Change

    The replacement of @UIApplicationMain with @main is a Swift 5.3+ feature that changes the application entry point. While this is a modernization, verify that the minimum iOS version (13.0) and Swift version support this attribute, and ensure all deployment targets are compatible.

    @main
    Version Consistency

    Flutter version is hardcoded in multiple places (lines 19, 32, 67) as "3.32.0". Consider using a workflow variable or environment variable to maintain consistency and simplify future version updates across all jobs.

            flutter-version: "3.32.0" # Set the desired Flutter version here
            channel: "stable"
        - name: Install Dependencies
          run: flutter pub get && cd sample && flutter pub get && cd ..
        - name: Lint Flutter
          run: dart format . --set-exit-if-changed && flutter analyze
    Android:
      runs-on: ubuntu-latest
      env:
        GRADLE_OPTS: "-Dorg.gradle.vfs.watch=false"
      timeout-minutes: 10
      strategy:
        matrix:
          flutter-version: ["3.32.0"]
      steps:
        - uses: actions/checkout@v5
        - uses: actions/setup-java@v5
          with:
            distribution: temurin
            java-version: 17
        - name: Setup Gradle
          uses: gradle/actions/setup-gradle@v5
        - uses: subosito/flutter-action@v2
          with:
            flutter-version: ${{ matrix.flutter-version }}
            channel: "stable"
        - name: Install Dependencies
          run: flutter pub get && cd sample && flutter pub get && cd ..
        - name: Lint Android
          uses: musichin/ktlint-check@v3
          with:
            ktlint-version: "1.7.0"
            patterns: |
              **/**.kt
              !**/**.g.kt
              !**/generated/**
        - name: Test
          run: flutter test && cd sample && flutter test && cd ..
        - name: Build Android Sample App
          run: cd sample && flutter build apk && cd ..
    iOS:
      runs-on: macos-15
      timeout-minutes: 10
      steps:
        - uses: actions/checkout@v5
        - run: touch sample/ios/smile_config.json
        - uses: subosito/flutter-action@v2
          with:
            flutter-version: "3.32.0" # Set the desired Flutter version here

    Comment on lines +69 to +72
    - name: Select Xcode 16.4
    uses: maxim-lobanov/setup-xcode@v1
    with:
    xcode-version: "16.4"
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggestion: Xcode 16.4 does not exist as of November 2025. The latest stable Xcode version is 16.1. Using a non-existent version will cause the workflow to fail. Verify the correct Xcode version for macOS 15 compatibility. [possible issue, importance: 9]

    Suggested change
    - name: Select Xcode 16.4
    uses: maxim-lobanov/setup-xcode@v1
    with:
    xcode-version: "16.4"
    - name: Select Xcode 16.1
    uses: maxim-lobanov/setup-xcode@v1
    with:
    xcode-version: "16.1"

    @tobitech tobitech merged commit 1d15e66 into main Nov 10, 2025
    6 checks passed
    @tobitech tobitech deleted the update-ios-sdk-version branch November 10, 2025 13:04
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants