-
Notifications
You must be signed in to change notification settings - Fork 24
Migrate to SPM 🥷 #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Migrate to SPM 🥷 #211
Changes from 16 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
787ee38
spm support on sample app
jumaallan 5aa3ad8
migrate flutter to SPM
jumaallan 639805c
fixed spm setup for flutter
jumaallan ccf6dc8
Update Package.swift
jumaallan b5dfe20
delete cocoapods integration
jumaallan eaca664
swift fixes
jumaallan 22ad2bd
enable SPM on CI
jumaallan 2459d5e
enable SPM on CI
jumaallan eed75c2
updated SPM config and removed Cocoapods in SPM
jumaallan b19ed4d
updated SPM config and removed Cocoapods in SPM
jumaallan 6bcebef
no idea why this is still failing
jumaallan e4b9d0d
version updates
jumaallan 5b27344
updated workflow
jumaallan ac554b7
Update build.yaml
jumaallan a0327ec
Update build.yaml
jumaallan 8d03efe
Update build.yaml
jumaallan 1f14359
update flutter build
jumaallan e165f11
updated build steps to enable SPM
jumaallan f17511d
optimize the workflow
jumaallan 4d09a4f
fix SPM config per directory change
jumaallan 6da1efe
Update build.yaml
jumaallan 2927044
Update Package.swift
jumaallan ad634e3
temp workaround
jumaallan 86b1279
Merge branch 'main' into migrate-to-spm
jumaallan caba9bc
updated depencies
jumaallan c5aa06a
updated SmileID SDK
jumaallan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,4 +33,7 @@ build/ | |
| .fvm/ | ||
| smile_config.json | ||
|
|
||
| sample/android/app/.cxx | ||
| sample/android/app/.cxx | ||
|
|
||
| .build/ | ||
| .swiftpm/ | ||
Empty file.
This file was deleted.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| // swift-tools-version: 5.9 | ||
|
|
||
| import PackageDescription | ||
|
|
||
| let package = Package( | ||
| name: "smile_id", | ||
| platforms: [ | ||
| .iOS("13.0") | ||
| ], | ||
| products: [ | ||
| .library(name: "smile-id", targets: ["smile_id"]) | ||
| ], | ||
| dependencies: [ | ||
| .package(url: "https://github.com/smileidentity/ios.git", .upToNextMajor(from: "11.1.2")), | ||
| .package(url: "https://github.com/weichsel/ZIPFoundation.git", exact: "0.9.20"), | ||
| .package(url: "https://github.com/airbnb/lottie-spm", exact: "4.5.2"), | ||
| .package(url: "https://github.com/fingerprintjs/fingerprintjs-ios", exact: "1.6.0"), | ||
| .package(url: "https://github.com/smileidentity/smile-id-security", exact: "11.1.2"), | ||
| .package(url: "https://github.com/getsentry/sentry-cocoa", exact: "8.57.0") | ||
|
|
||
| ], | ||
| targets: [ | ||
| .target( | ||
| name: "smile_id", | ||
| dependencies: [ | ||
| "SmileIDSDK", | ||
| .product(name: "ZIPFoundation", package: "ZIPFoundation"), | ||
| .product(name: "Lottie", package: "lottie-spm"), | ||
| .product(name: "FingerprintJS", package: "fingerprintjs-ios"), | ||
| .product(name: "Sentry", package: "sentry-cocoa"), | ||
| .product(name: "SmileIDSecurity", package: "smile-id-security") | ||
| ], | ||
| ), | ||
| .binaryTarget( | ||
| name: "SmileIDSDK", | ||
| url: "https://github.com/smileidentity/ios/releases/download/v11.1.2/SmileIDSDK.xcframework.zip", | ||
| checksum: "623d441897a824e7bf7ed41ac55565d27bc266d4f5872ff94f40043dd7654b42" | ||
| ) | ||
| ] | ||
| ) |
File renamed without changes.
3 changes: 2 additions & 1 deletion
3
ios/Classes/Mapper.swift → ios/smile_id/Sources/smile_id/Mapper.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
ios/Classes/SmileIDBiometricKYC.swift → ...ources/smile_id/SmileIDBiometricKYC.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
ios/Classes/SmileIDDictExt.swift → ..._id/Sources/smile_id/SmileIDDictExt.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
ios/Classes/SmileIDDocumentCaptureView.swift → ...smile_id/SmileIDDocumentCaptureView.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...Classes/SmileIDDocumentVerification.swift → ...mile_id/SmileIDDocumentVerification.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...SmileIDEnhancedDocumentVerification.swift → ...SmileIDEnhancedDocumentVerification.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
2 changes: 1 addition & 1 deletion
2
ios/Classes/SmileIDPlugin.swift → ...e_id/Sources/smile_id/SmileIDPlugin.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...es/SmileIDSmartSelfieAuthentication.swift → ...id/SmileIDSmartSelfieAuthentication.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...IDSmartSelfieAuthenticationEnhanced.swift → ...IDSmartSelfieAuthenticationEnhanced.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...asses/SmileIDSmartSelfieCaptureView.swift → ...le_id/SmileIDSmartSelfieCaptureView.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...lasses/SmileIDSmartSelfieEnrollment.swift → ...ile_id/SmileIDSmartSelfieEnrollment.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...mileIDSmartSelfieEnrollmentEnhanced.swift → ...mileIDSmartSelfieEnrollmentEnhanced.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 2 additions & 1 deletion
3
ios/Classes/SmileIDUtils.swift → ...le_id/Sources/smile_id/SmileIDUtils.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| import Foundation | ||
| import SmileID | ||
| import SmileIDSDK | ||
| import UIKit | ||
|
|
||
| extension String { | ||
| func isValidUrl() -> Bool { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.