Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/ksef_client/services/workflows.py
Original file line number Diff line number Diff line change
Expand Up @@ -965,6 +965,9 @@ def download_and_process_package(
package: InvoicePackage,
encryption_data: EncryptionData,
) -> PackageProcessingResult:
if package.invoice_count == 0:
return PackageProcessingResult(metadata_summaries=[], invoice_xml_files={})

encrypted_parts_with_hash = self._download_helper.download_parts_with_hash(package.parts)
for index, (part_bytes, part_hash) in enumerate(encrypted_parts_with_hash, start=1):
_validate_export_part_hash(
Expand Down Expand Up @@ -1016,6 +1019,9 @@ async def download_and_process_package(
package: InvoicePackage,
encryption_data: EncryptionData,
) -> PackageProcessingResult:
if package.invoice_count == 0:
return PackageProcessingResult(metadata_summaries=[], invoice_xml_files={})

encrypted_parts_with_hash = await self._download_helper.download_parts_with_hash(
package.parts
)
Expand Down
59 changes: 59 additions & 0 deletions tests/test_services_workflows.py
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,17 @@ def _invoice_package(url: str = "https://download") -> m.InvoicePackage:
)


def _empty_invoice_package() -> m.InvoicePackage:
return m.InvoicePackage.from_dict(
{
"invoiceCount": 0,
"size": 0,
"isTruncated": False,
"parts": [],
}
)


def _form_code() -> m.FormCode:
return m.FormCode(system_code="FA", schema_version="1-0E", value="FA")

Expand Down Expand Up @@ -622,6 +633,27 @@ class DummyInvoices:
self.assertEqual(result.metadata_summaries[0]["ksefNumber"], "1")
self.assertIn("inv.xml", result.invoice_xml_files)

def test_export_workflow_empty_invoice_package_returns_empty_result(self):
encryption = workflows.EncryptionData(
key=generate_symmetric_key(),
iv=generate_iv(),
encryption_info=None,
)

class DummyInvoices:
pass

workflow = workflows.ExportWorkflow(cast(InvoicesClient, DummyInvoices()), RecordingHttp())
with patch.object(
workflow._download_helper,
"download_parts_with_hash",
side_effect=AssertionError("empty export package should not be downloaded"),
):
result = workflow.download_and_process_package(_empty_invoice_package(), encryption)

self.assertEqual(result.metadata_summaries, [])
self.assertEqual(result.invoice_xml_files, {})

def test_export_workflow_ignores_non_xml_non_metadata_files(self):
key = generate_symmetric_key()
iv = generate_iv()
Expand Down Expand Up @@ -963,6 +995,33 @@ class DummyInvoices:
result = await workflow.download_and_process_package(_invoice_package("u"), encryption)
self.assertEqual(result.metadata_summaries[0]["ksefNumber"], "1")

async def test_async_export_workflow_empty_invoice_package_returns_empty_result(self):
encryption = workflows.EncryptionData(
key=generate_symmetric_key(),
iv=generate_iv(),
encryption_info=None,
)

class DummyInvoices:
pass

workflow = workflows.AsyncExportWorkflow(
cast(AsyncInvoicesClient, DummyInvoices()),
RecordingAsyncHttp(),
)
with patch.object(
workflow._download_helper,
"download_parts_with_hash",
AsyncMock(side_effect=AssertionError("empty export package should not be downloaded")),
):
result = await workflow.download_and_process_package(
_empty_invoice_package(),
encryption,
)

self.assertEqual(result.metadata_summaries, [])
self.assertEqual(result.invoice_xml_files, {})

async def test_async_export_workflow_ignores_non_xml_non_metadata_files(self):
key = generate_symmetric_key()
iv = generate_iv()
Expand Down
Loading