Skip to content

Bugfix/java ee maven #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Bugfix/java ee maven #1370

wants to merge 3 commits into from

Conversation

RHenigan
Copy link
Contributor

@RHenigan RHenigan commented Jun 5, 2020

Fixes #1369

This PR is [not ready] for review.

Risk

This PR makes [no] API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
  • I have tested Java EE

Summary

This branch will replace hello_sdl_java_ee with a new version that is a maven project. This project will work with glassfish and make it easier for developers to follow and make it easier to include dependencies.

CLA

@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #1370 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1370   +/-   ##
==========================================
  Coverage      47.52%   47.52%           
  Complexity      4441     4441           
==========================================
  Files            489      489           
  Lines          23972    23972           
  Branches        2775     2775           
==========================================
  Hits           11392    11392           
  Misses         11882    11882           
  Partials         698      698           

@RHenigan RHenigan closed this Jun 5, 2020
@RHenigan RHenigan deleted the bugfix/JavaEE_Maven branch June 5, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant