Fix for dial number behaviour #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dial number should send rejected if there is an alert that is being displayed
|
@JackLivio I think this should be implemented in SendLocation too. And I don't how many more methods actually follow this flow like dialnumber and sendlocation. And according to the documentation Emergency call is higher priority than alert, So Emergency call, alert comes under high priority messages. I think we should find a generic solution that it should check for priorities before displaying. |
sandeepf184
reviewed
Sep 24, 2016
| @@ -407,6 +407,15 @@ FFW.BasicCommunication = FFW.RPCObserver | |||
| ); | |||
| } | |||
| if (request.method == 'BasicCommunication.DialNumber') { | |||
| if (SDL.AlertPopUp.active) { | |||
There was a problem hiding this comment.
@JackLivio Is the AlertPopUp is a method of SDL RPC ???
AKalinich-Luxoft
added a commit
that referenced
this pull request
Jul 11, 2017
…edata_impl Implementation of Getinteriorvehicledata
Itileda
pushed a commit
to Itileda/sdl_hmi
that referenced
this pull request
Aug 18, 2017
…_in_front_of_name fix extra letter in front of appName
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dial number should send rejected if there is an alert that is being displayed