Script update for 1880 issue #2670
Conversation
|
PR is related to #2000 |
|
The issue smartdevicelink/sdl_core#3914 has been created according to result of scripts execution |
|
@theresalech, this PR is ready for Livio review. |
| m.sendUIresp = true | ||
| m.sendVRresp = true | ||
| m.notSendUIresp = false | ||
| m.notSsendVRresp = false |
There was a problem hiding this comment.
| m.notSsendVRresp = false | |
| m.notSendVRresp = false |
to keep it consistent with the notSendUIresp constant.
There was a problem hiding this comment.
Updated in 55775e3
| -- - start timeout <DefaultTimeout> + <*RPCs_own_timeout> for expecting VR response | ||
| -- 5. HMI does not respond to UI and VR requests during <DefaultTimeout> + <*RPCs_own_timeout> | ||
| -- SDL does: | ||
| -- - respond 'GENERIC_ERROR, success:false' to mobile app after <DefaultTimeout> + <*RPCs_own_timeout> is expired |
There was a problem hiding this comment.
This expectation is failing since core is not sending a GENERIC_ERROR response within that specified timeout.
[09:49:14,866] PerformInteraction_default_timeout_and_PI_timeout [FAIL] (21588 ms)
Response to 4: Timeout: Response to 4: Timeout expired
Looking at the core logs, this seems to be due to UpdateRequestTimeout being called in PerformInteractionRequest::OnTimeOut() for the BOTH interactionMode.
sdl_core/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/mobile/perform_interaction_request.cc:308 commands::PerformInteractionRequest::OnTimeOut: Enter
sdl_core/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/mobile/perform_interaction_request.cc:312 commands::PerformInteractionRequest::OnTimeOut: Interaction Mode: BOTH
sdl_core/src/components/application_manager/src/application_manager_impl.cc:3035 ApplicationManagerImpl::UpdateRequestTimeout: Enter
sdl_core/src/components/application_manager/src/request_controller_impl.cc:464 request_controller::RequestControllerImpl::UpdateRequestTimeout: Enter
sdl_core/src/components/application_manager/src/request_controller_impl.cc:465 request_controller::RequestControllerImpl::UpdateRequestTimeout: app_id : 65537 mobile_correlation_id : 4 new_timeout : 25000
sdl_core/src/components/application_manager/src/commands/command_request_impl.cc:180 commands::CommandRequestImpl::OnUpdateTimeOut: Enter
sdl_core/src/components/application_manager/src/commands/command_request_impl.cc:180 commands::CommandRequestImpl::OnUpdateTimeOut: Exit
sdl_core/src/components/application_manager/src/request_controller_impl.cc:702 request_controller::RequestControllerImpl::NotifyTimer: Enter
sdl_core/src/components/application_manager/src/request_controller_impl.cc:702 request_controller::RequestControllerImpl::NotifyTimer: Exit
sdl_core/src/components/application_manager/src/request_controller_impl.cc:489 request_controller::RequestControllerImpl::UpdateRequestTimeout: Timeout updated for app_id: 65537 correlation_id: 4 new_timeout (ms): 25000
sdl_core/src/components/application_manager/src/request_controller_impl.cc:464 request_controller::RequestControllerImpl::UpdateRequestTimeout: Exit
sdl_core/src/components/application_manager/src/application_manager_impl.cc:3035 ApplicationManagerImpl::UpdateRequestTimeout: Exit
sdl_core/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/mobile/perform_interaction_request.cc:308 commands::PerformInteractionRequest::OnTimeOut: Exit
There was a problem hiding this comment.
The issue smartdevicelink/sdl_core#3914 has been created according to scripts result.
This issue collects issues with timeouts for PerformInteraction, so maybe a merge of this issue should be related to the fix of smartdevicelink/sdl_core#3914
There was a problem hiding this comment.
I see, in that case I think #3914 should be added to the PR title and/or description
There was a problem hiding this comment.
Added 3914 to the description
ATF Test Scripts to check #1880 and #3914
This PR is ready for review.
Summary
Script update for 1880 issue and coverage for 3914
ATF version
develop
Changelog
CLA