[CRE] vault DKG: allow committee-shrinking reshares - #23624
Open
prashantkumar1982 wants to merge 1 commit into
Open
[CRE] vault DKG: allow committee-shrinking reshares#23624prashantkumar1982 wants to merge 1 commit into
prashantkumar1982 wants to merge 1 commit into
Conversation
ConfigureVaultDKG.VerifyPreconditions tied len(NodeIDs) to len(RecipientPublicKeys), which blocks a reshare that removes a node: smdkg requires the reshare to be run by the outgoing committee (N == number of dealers == prior recipients), while the new recipient set is smaller. Split the length check by run type: - Fresh DKG (no previousInstanceID): nodeIDs == dealers == recipients (all equal, dealers==recipients). - Reshare: len(nodeIDs) == len(dealerPublicKeys); recipients may differ. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
product-security-plaid-production
Bot
requested review from
giogam and
mchain0
September 2, 2026 10:46
Contributor
|
👋 prashantkumar1982, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
|
✅ No conflicts with other open PRs targeting |
cedric-cordenier
approved these changes
Sep 2, 2026
russell-stern
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ConfigureVaultDKG.VerifyPreconditionsrequiredlen(NodeIDs) == len(RecipientPublicKeys). That makes it impossible to express a reshare that removes a node.A DKG reshare must be run by the outgoing committee — only they hold shares to re-deal — so the OCR instance size
N(=len(NodeIDs)) must equal the dealer set (= the previous instance's recipients). The new recipient set can legitimately be smaller. The fixed smdkg enforceslen(dealers) == N, so with the old precondition a shrink hits: